Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: o3read - Standalone converter for OpenOffice.org documents https://bugzilla.redhat.com/show_bug.cgi?id=429483 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Summary|Review Request: o3read - |Review Request: o3read - |Standalone converter for |Standalone converter for |OpenOffice.org documents |OpenOffice.org documents Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-01-21 03:13 EST ------- This is pretty simple; it builds fine, rpmlint is silent and I can't fine any issues. * source files match upstream: 3704b448099d3396bec4cf503c298628c815703aae12bfcddbac4444bc786430 o3read-0.0.4.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper (none). * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane. * %check is not present; no test suite upstream. I did some light testing and things seem to work as advertised. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review