https://bugzilla.redhat.com/show_bug.cgi?id=2271417 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2". 61 files have unknown license. Detailed output of licensecheck in /home/fedora/2271417-gap-pkg-permut/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/gap/pkg, /usr/share/gap [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 6347 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: gap-pkg-permut-2.0.5-1.fc41.noarch.rpm gap-pkg-permut-doc-2.0.5-1.fc41.noarch.rpm gap-pkg-permut-2.0.5-1.fc41.src.rpm ========================================= rpmlint session starts ======================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpv9j7xup2')] checks: 32, packages: 3 gap-pkg-permut.noarch: E: spelling-error ('Permutability', 'Summary(en_US) Permutability -> Per mutability, Per-mutability, Permeability') gap-pkg-permut.noarch: E: spelling-error ('permutability', '%description -l en_US permutability -> per mutability, per-mutability, permeability') gap-pkg-permut.src: E: spelling-error ('Permutability', 'Summary(en_US) Permutability -> Per mutability, Per-mutability, Permeability') gap-pkg-permut.src: E: spelling-error ('permutability', '%description -l en_US permutability -> per mutability, per-mutability, permeability') gap-pkg-permut-doc.noarch: W: no-documentation gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/chooser.html ../../GAPDoc/styles/chooser.html gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/lefttoc.css ../../GAPDoc/styles/lefttoc.css gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/manual.css ../../GAPDoc/styles/manual.css gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/manual.js ../../GAPDoc/styles/manual.js gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/nocolorprompt.css ../../GAPDoc/styles/nocolorprompt.css gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/ragged.css ../../GAPDoc/styles/ragged.css gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/rainbow.js ../../GAPDoc/styles/rainbow.js gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/times.css ../../GAPDoc/styles/times.css gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/toggless.css ../../GAPDoc/styles/toggless.css gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/toggless.js ../../GAPDoc/styles/toggless.js === 3 packages and 0 specfiles checked; 4 errors, 11 warnings, 12 filtered, 4 badness; has taken 0.5 s == Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 gap-pkg-permut.noarch: E: spelling-error ('Permutability', 'Summary(en_US) Permutability -> Per mutability, Per-mutability, Permeability') gap-pkg-permut.noarch: E: spelling-error ('permutability', '%description -l en_US permutability -> per mutability, per-mutability, permeability') gap-pkg-permut-doc.noarch: W: no-documentation gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/chooser.html ../../GAPDoc/styles/chooser.html gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/lefttoc.css ../../GAPDoc/styles/lefttoc.css gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/manual.css ../../GAPDoc/styles/manual.css gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/manual.js ../../GAPDoc/styles/manual.js gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/nocolorprompt.css ../../GAPDoc/styles/nocolorprompt.css gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/ragged.css ../../GAPDoc/styles/ragged.css gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/rainbow.js ../../GAPDoc/styles/rainbow.js gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/times.css ../../GAPDoc/styles/times.css gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/toggless.css ../../GAPDoc/styles/toggless.css gap-pkg-permut-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/permut/doc/toggless.js ../../GAPDoc/styles/toggless.js 2 packages and 0 specfiles checked; 2 errors, 11 warnings, 8 filtered, 2 badness; has taken 0.2 s Source checksums ---------------- https://github.com/gap-packages/permut/releases/download/v2.0.5/permut-2.0.5.tar.bz2 : CHECKSUM(SHA256) this package : 4e8565fd74a34d55ec686bc80beda013a9f4050fb0176455fccbfe0eac72caec CHECKSUM(SHA256) upstream package : 4e8565fd74a34d55ec686bc80beda013a9f4050fb0176455fccbfe0eac72caec Requires -------- gap-pkg-permut (rpmlib, GLIBC filtered): gap-pkg-format gap-pkg-permut-doc (rpmlib, GLIBC filtered): gap-online-help gap-pkg-format-doc gap-pkg-permut Provides -------- gap-pkg-permut: gap-pkg-permut gap-pkg-permut-doc: gap-pkg-permut-doc Diff spec file in url and in SRPM --------------------------------- --- /home/fedora/2271417-gap-pkg-permut/srpm/gap-pkg-permut.spec 2024-03-25 18:39:49.231601813 +0000 +++ /home/fedora/2271417-gap-pkg-permut/srpm-unpacked/gap-pkg-permut.spec 2024-03-25 00:00:00.000000000 +0000 @@ -31,5 +31,6 @@ # Nimbus: AGPL-3.0-only # RSFS: LicenseRef-Rsfs -License: GPL-2.0-or-later AND OFL-1.1-RFN AND Knuth-CTAN AND AGPL-3.0-only AND LicenseRef-Rsfs +# StandardSymL: GPL-1.0-or-later +License: GPL-2.0-or-later AND OFL-1.1-RFN AND Knuth-CTAN AND AGPL-3.0-only AND LicenseRef-Rsfs AND GPL-1.0-or-later Summary: Permut documentation Requires: %{name} = %{version}-%{release} Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2271417 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Shell-api Disabled plugins: C/C++, PHP, Ocaml, Python, Java, R, Haskell, Perl, SugarActivity, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Some warnings: + gap makedoc.g ┌───────┐ GAP 4.13.0 of 2024-03-15 │ GAP │ https://www.gap-system.org └───────┘ Architecture: aarch64-redhat-linux-gnu-default64-kv9 Configuration: gmp 6.3.0, GASMAN, readline Loading the library and packages ... #I autpgrp package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I alnuth package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I crisp package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I ctbllib package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I factint package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I fga package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I irredsol package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I laguna package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I polenta package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I polycyclic package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I resclasses package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I sophus package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') #I tomlib package is not available. Check that the name is correct #I and it is present in one of the GAP root directories (see '??RootPaths') b) Nice that javascript and css files are shared across GAP packages c) Directory ownership seems to be a bug with Fedora-review d) Approved e) Review of one of: https://bugzilla.redhat.com/show_bug.cgi?id=2271521 https://bugzilla.redhat.com/show_bug.cgi?id=2271504 https://bugzilla.redhat.com/show_bug.cgi?id=2269966 https://bugzilla.redhat.com/show_bug.cgi?id=2268776 would be appreciated. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2271417 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202271417%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
