https://bugzilla.redhat.com/show_bug.cgi?id=2271264 --- Comment #6 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: systemc : /usr/share/licenses/systemc/copyright.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "FSF Unlimited License [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "GNU General Public License", "X11 License [generated file]", "FSF Unlimited License (with License Retention) and/or GNU General Public License v2.0 or later", "GNU General Public License v2.0 or later", "FSF Unlimited License (with License Retention)", "Apache License 2.0", "*No copyright* Boost Software License 1.0", "Boost Software License 1.0", "Boost Software License 1.0 [generated file]", "Historical Permission Notice and Disclaimer", "Boost Software License 1.0 and/or NTP License". 299 files have unknown license. Detailed output of licensecheck in /home/fedora/2271264-systemc/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/cmake [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: systemc-devel (description) [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 104811 bytes in 7 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in systemc- devel [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: systemc-2.3.4-1.fc41.aarch64.rpm systemc-devel-2.3.4-1.fc41.aarch64.rpm systemc-debuginfo-2.3.4-1.fc41.aarch64.rpm systemc-debugsource-2.3.4-1.fc41.aarch64.rpm systemc-2.3.4-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmprbqmdqne')] checks: 32, packages: 5 systemc-devel.aarch64: W: unexpanded-macro %description -l C %{base_description} systemc-devel.aarch64: W: no-documentation systemc.aarch64: W: name-repeated-in-summary SystemC systemc.src: W: name-repeated-in-summary SystemC systemc.aarch64: W: files-duplicate /usr/share/licenses/systemc/LICENSE /usr/share/doc/systemc/LICENSE systemc.aarch64: W: files-duplicate /usr/share/licenses/systemc/NOTICE /usr/share/doc/systemc/NOTICE systemc.aarch64: W: devel-file-in-non-devel-package /usr/share/licenses/systemc/copyright.h 5 packages and 0 specfiles checked; 0 errors, 7 warnings, 39 filtered, 0 badness; has taken 1.5 s Rpmlint (debuginfo) ------------------- Checking: systemc-debuginfo-2.3.4-1.fc41.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0k4yeej9')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 systemc-devel.aarch64: W: unexpanded-macro %description -l C %{base_description} systemc.aarch64: E: undefined-non-weak-symbol /usr/lib64/libsystemc.so.2.3.4 sc_main (/usr/lib64/libsystemc.so.2.3.4) systemc-devel.aarch64: W: no-documentation systemc.aarch64: W: name-repeated-in-summary SystemC systemc.aarch64: W: files-duplicate /usr/share/licenses/systemc/LICENSE /usr/share/doc/systemc/LICENSE systemc.aarch64: W: files-duplicate /usr/share/licenses/systemc/NOTICE /usr/share/doc/systemc/NOTICE systemc.aarch64: W: devel-file-in-non-devel-package /usr/share/licenses/systemc/copyright.h 4 packages and 0 specfiles checked; 1 errors, 6 warnings, 34 filtered, 1 badness; has taken 1.4 s Source checksums ---------------- https://github.com/accellera-official/systemc/archive/refs/tags/2.3.4.tar.gz : CHECKSUM(SHA256) this package : bfb309485a8ad35a08ee78827d1647a451ec5455767b25136e74522a6f41e0ea CHECKSUM(SHA256) upstream package : bfb309485a8ad35a08ee78827d1647a451ec5455767b25136e74522a6f41e0ea Requires -------- systemc (rpmlib, GLIBC filtered): ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) systemc-devel (rpmlib, GLIBC filtered): cmake-filesystem(aarch-64) libsystemc.so.2.3()(64bit) systemc systemc-debuginfo (rpmlib, GLIBC filtered): systemc-debugsource (rpmlib, GLIBC filtered): Provides -------- systemc: libsystemc.so.2.3()(64bit) systemc systemc(aarch-64) systemc-devel: cmake(SystemCLanguage) cmake(SystemCTLM) cmake(systemclanguage) cmake(systemctlm) systemc-devel systemc-devel(aarch-64) systemc-debuginfo: debuginfo(build-id) libsystemc.so.2.3.4-2.3.4-1.fc41.aarch64.debug()(64bit) systemc-debuginfo systemc-debuginfo(aarch-64) systemc-debugsource: systemc-debugsource systemc-debugsource(aarch-64) Diff spec file in url and in SRPM --------------------------------- --- /home/fedora/2271264-systemc/srpm/systemc.spec 2024-03-25 09:42:47.254992288 +0000 +++ /home/fedora/2271264-systemc/srpm-unpacked/systemc.spec 2024-03-24 00:00:00.000000000 +0000 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.6.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + Name: systemc Version: 2.3.4 @@ -59,10 +69,10 @@ %install # Remove extra debug file -rm -rf %{buildroot}%{_prefix}/lib/debug/%{_libdir}/libsystemc.so.* +rm -rf %{buildroot}/usr/lib/debug/%{_libdir}/libsystemc.so.* %cmake_install %files -%license LICENSE NOTICE +%license LICENSE NOTICE src/sysc/packages/qt/copyright.h %doc %{_datadir}/doc/systemc %{_libdir}/libsystemc.so.* @@ -76,3 +86,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Sun Mar 24 2024 John Doe <packager@xxxxxxxxxxx> - 2.3.4-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2271264 Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: PHP, Haskell, Perl, SugarActivity, Python, Java, fonts, R, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Please reference the source using: https://github.com/OWNER/PROJECT/archive/%{gittag}/%{name}-%{version}.tar.gz see: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_hosting_services b) check section usually comes after install section in the spec file c) Change Requires: %{name} = %{version}-%{release} to Requires: %{name}%{?_isa} = %{version}-%{release} to ensure correct architecture is pulled in d) Can the patch that fixes failing builds on s390x and ppc be applied, alternatively, it is ok to package a commit rather than wait for the next release. e) There are a number of files with Boost Software license: Boost Software License 1.0 -------------------------- systemc-2.3.4/src/sysc/packages/boost/bind.hpp systemc-2.3.4/src/sysc/packages/boost/bind/apply.hpp systemc-2.3.4/src/sysc/packages/boost/bind/arg.hpp systemc-2.3.4/src/sysc/packages/boost/bind/bind_cc.hpp systemc-2.3.4/src/sysc/packages/boost/bind/bind_mf_cc.hpp systemc-2.3.4/src/sysc/packages/boost/bind/bind_template.hpp systemc-2.3.4/src/sysc/packages/boost/bind/make_adaptable.hpp systemc-2.3.4/src/sysc/packages/boost/bind/mem_fn_cc.hpp systemc-2.3.4/src/sysc/packages/boost/bind/mem_fn_template.hpp systemc-2.3.4/src/sysc/packages/boost/bind/mem_fn_vw.hpp systemc-2.3.4/src/sysc/packages/boost/bind/placeholders.hpp systemc-2.3.4/src/sysc/packages/boost/bind/protect.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/borland.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/comeau.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/common_edg.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/compaq_cxx.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/digitalmars.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/gcc.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/greenhills.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/hp_acc.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/intel.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/kai.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/metrowerks.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/mpw.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/sgi_mipspro.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/sunpro_cc.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/vacpp.hpp systemc-2.3.4/src/sysc/packages/boost/config/compiler/visualc.hpp systemc-2.3.4/src/sysc/packages/boost/config/platform/aix.hpp systemc-2.3.4/src/sysc/packages/boost/config/platform/amigaos.hpp systemc-2.3.4/src/sysc/packages/boost/config/platform/beos.hpp systemc-2.3.4/src/sysc/packages/boost/config/platform/bsd.hpp systemc-2.3.4/src/sysc/packages/boost/config/platform/cygwin.hpp systemc-2.3.4/src/sysc/packages/boost/config/platform/hpux.hpp systemc-2.3.4/src/sysc/packages/boost/config/platform/irix.hpp systemc-2.3.4/src/sysc/packages/boost/config/platform/linux.hpp systemc-2.3.4/src/sysc/packages/boost/config/platform/macos.hpp systemc-2.3.4/src/sysc/packages/boost/config/platform/solaris.hpp systemc-2.3.4/src/sysc/packages/boost/config/platform/win32.hpp systemc-2.3.4/src/sysc/packages/boost/config/posix_features.hpp systemc-2.3.4/src/sysc/packages/boost/config/select_compiler_config.hpp systemc-2.3.4/src/sysc/packages/boost/config/select_platform_config.hpp systemc-2.3.4/src/sysc/packages/boost/config/select_stdlib_config.hpp systemc-2.3.4/src/sysc/packages/boost/config/stdlib/dinkumware.hpp systemc-2.3.4/src/sysc/packages/boost/config/stdlib/libcomo.hpp systemc-2.3.4/src/sysc/packages/boost/config/stdlib/libstdcpp3.hpp systemc-2.3.4/src/sysc/packages/boost/config/stdlib/modena.hpp systemc-2.3.4/src/sysc/packages/boost/config/stdlib/msl.hpp systemc-2.3.4/src/sysc/packages/boost/config/stdlib/roguewave.hpp systemc-2.3.4/src/sysc/packages/boost/config/stdlib/sgi.hpp systemc-2.3.4/src/sysc/packages/boost/config/stdlib/stlport.hpp systemc-2.3.4/src/sysc/packages/boost/config/stdlib/vacpp.hpp systemc-2.3.4/src/sysc/packages/boost/config/suffix.hpp systemc-2.3.4/src/sysc/packages/boost/config/user.hpp systemc-2.3.4/src/sysc/packages/boost/detail/workaround.hpp systemc-2.3.4/src/sysc/packages/boost/get_pointer.hpp systemc-2.3.4/src/sysc/packages/boost/mem_fn.hpp systemc-2.3.4/src/sysc/packages/boost/mpl/aux_/adl_barrier.hpp systemc-2.3.4/src/sysc/packages/boost/mpl/aux_/config/adl.hpp systemc-2.3.4/src/sysc/packages/boost/mpl/aux_/config/gcc.hpp systemc-2.3.4/src/sysc/packages/boost/mpl/aux_/config/intel.hpp systemc-2.3.4/src/sysc/packages/boost/mpl/aux_/config/msvc.hpp systemc-2.3.4/src/sysc/packages/boost/mpl/aux_/config/static_constant.hpp systemc-2.3.4/src/sysc/packages/boost/mpl/aux_/config/workaround.hpp systemc-2.3.4/src/sysc/packages/boost/mpl/bool.hpp systemc-2.3.4/src/sysc/packages/boost/mpl/bool_fwd.hpp systemc-2.3.4/src/sysc/packages/boost/mpl/integral_c_tag.hpp systemc-2.3.4/src/sysc/packages/boost/non_type.hpp systemc-2.3.4/src/sysc/packages/boost/ref.hpp systemc-2.3.4/src/sysc/packages/boost/type.hpp systemc-2.3.4/src/sysc/packages/boost/utility/addressof.hpp systemc-2.3.4/src/sysc/packages/boost/utility/enable_if.hpp systemc-2.3.4/src/sysc/packages/boost/utility/string_view.hpp systemc-2.3.4/src/sysc/packages/boost/utility/string_view_fwd.hpp Boost Software License 1.0 [generated file] ------------------------------------------- systemc-2.3.4/src/sysc/packages/boost/config.hpp Boost Software License 1.0 and/or NTP License --------------------------------------------- systemc-2.3.4/src/sysc/packages/boost/detail/endian.hpp However, current head of repository seems to have removed them. e) There is also: Historical Permission Notice and Disclaimer ------------------------------------------- systemc-2.3.4/src/sysc/packages/qt/INSTALL f) LICENSE and NOTICE are packaged twice in /usr/share/doc /usr/share/license g) copyright.h from QuickThreads should also be markes as a license file, perhaps it can be renamed? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2271264 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202271264%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
