https://bugzilla.redhat.com/show_bug.cgi?id=2193288 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) | --- Comment #19 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils) - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License", "MIT License". 903 files have unknown license. Detailed output of licensecheck in /home/fedora/2193288-f3d/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/mime, /usr/lib64/python3.12/site- packages, /usr/share/icons/hicolor/scalable, /usr/lib64/cmake, /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/32x32/apps, /usr/share/java, /usr/lib64/python3.12, /usr/share/thumbnailers, /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/scalable/apps, /usr/share/mime/packages, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/thumbnailers [ ]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4708 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build Maven: [-]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [!]: Packages are noarch unless they use JNI Note: f3d subpackage is not noarch. Please verify manually [x]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: f3d-2.3.0-1.fc41.aarch64.rpm f3d-devel-2.3.0-1.fc41.aarch64.rpm f3d-python3-2.3.0-1.fc41.aarch64.rpm f3d-java-2.3.0-1.fc41.aarch64.rpm f3d-debuginfo-2.3.0-1.fc41.aarch64.rpm f3d-debugsource-2.3.0-1.fc41.aarch64.rpm f3d-2.3.0-1.fc41.src.rpm ========================================= rpmlint session starts ======================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpcz8fhq0x')] checks: 32, packages: 7 f3d.aarch64: E: spelling-error ('glTF', '%description -l en_US glTF -> glut') f3d.aarch64: E: spelling-error ('raytracing', '%description -l en_US raytracing -> ray tracing, ray-tracing, tracing') f3d.src: E: spelling-error ('glTF', '%description -l en_US glTF -> glut') f3d.src: E: spelling-error ('raytracing', '%description -l en_US raytracing -> ray tracing, ray-tracing, tracing') f3d.spec: W: patch-not-applied Patch0: https://github.com/f3d-app/f3d/pull/1225.patch f3d-devel.aarch64: W: no-documentation f3d-java.aarch64: W: no-documentation f3d-python3.aarch64: W: no-documentation f3d-java.aarch64: E: invalid-soname /usr/lib64/libf3d-java.so libf3d-java.so f3d.aarch64: W: files-duplicate /usr/share/f3d/configs/thumbnail.d/10_alembic.json /usr/share/f3d/configs/config.d/10_alembic.json f3d.aarch64: W: files-duplicate /usr/share/f3d/configs/thumbnail.d/10_assimp.json /usr/share/f3d/configs/config.d/10_assimp.json f3d.aarch64: W: files-duplicate /usr/share/f3d/configs/thumbnail.d/10_draco.json /usr/share/f3d/configs/config.d/10_draco.json f3d.aarch64: W: files-duplicate /usr/share/f3d/configs/thumbnail.d/10_occt.json /usr/share/f3d/configs/config.d/10_occt.json === 7 packages and 0 specfiles checked; 5 errors, 8 warnings, 54 filtered, 5 badness; has taken 2.4 s === Rpmlint (debuginfo) ------------------- Checking: f3d-debuginfo-2.3.0-1.fc41.aarch64.rpm f3d-java-debuginfo-2.3.0-1.fc41.aarch64.rpm ========================================= rpmlint session starts ======================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmphufyaz3p')] checks: 32, packages: 2 === 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 27 filtered, 0 badness; has taken 0.8 s === Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 7 f3d.aarch64: E: spelling-error ('glTF', '%description -l en_US glTF -> glut') f3d.aarch64: E: spelling-error ('raytracing', '%description -l en_US raytracing -> ray tracing, ray-tracing, tracing') f3d-devel.aarch64: W: no-documentation f3d-java.aarch64: W: no-documentation f3d-python3.aarch64: W: no-documentation f3d-java.aarch64: E: invalid-soname /usr/lib64/libf3d-java.so libf3d-java.so f3d.aarch64: W: files-duplicate /usr/share/f3d/configs/thumbnail.d/10_alembic.json /usr/share/f3d/configs/config.d/10_alembic.json f3d.aarch64: W: files-duplicate /usr/share/f3d/configs/thumbnail.d/10_assimp.json /usr/share/f3d/configs/config.d/10_assimp.json f3d.aarch64: W: files-duplicate /usr/share/f3d/configs/thumbnail.d/10_draco.json /usr/share/f3d/configs/config.d/10_draco.json f3d.aarch64: W: files-duplicate /usr/share/f3d/configs/thumbnail.d/10_occt.json /usr/share/f3d/configs/config.d/10_occt.json 7 packages and 0 specfiles checked; 3 errors, 7 warnings, 64 filtered, 3 badness; has taken 3.7 s Unversioned so-files -------------------- f3d: /usr/lib64/f3d/plugins/libf3d-plugin-alembic.so f3d: /usr/lib64/f3d/plugins/libf3d-plugin-assimp.so f3d: /usr/lib64/f3d/plugins/libf3d-plugin-draco.so f3d: /usr/lib64/f3d/plugins/libf3d-plugin-exodus.so f3d: /usr/lib64/f3d/plugins/libf3d-plugin-occt.so f3d-python3: /usr/lib64/python3.12/site-packages/f3d/pyf3d.cpython-312-aarch64-linux-gnu.so f3d-java: /usr/lib64/libf3d-java.so Source checksums ---------------- https://github.com/f3d-app/f3d/archive/v2.3.0/f3d-2.3.0.tar.gz : CHECKSUM(SHA256) this package : 9c2906b62f3066f075effbabd6501964391e8a8ffad6ed773c33db12580cc466 CHECKSUM(SHA256) upstream package : 9c2906b62f3066f075effbabd6501964391e8a8ffad6ed773c33db12580cc466 Requires -------- f3d (rpmlib, GLIBC filtered): hicolor-icon-theme ld-linux-aarch64.so.1()(64bit) libAlembic.so.1.8()(64bit) libGLEW.so.2.2()(64bit) libOpenGL.so.0()(64bit) libTKBRep.so.7()(64bit) libTKIGES.so.7()(64bit) libTKLCAF.so.7()(64bit) libTKMath.so.7()(64bit) libTKMesh.so.7()(64bit) libTKXCAF.so.7()(64bit) libTKXDEIGES.so.7()(64bit) libTKXDESTEP.so.7()(64bit) libTKXSBase.so.7()(64bit) libTKernel.so.7()(64bit) libassimp.so.5()(64bit) libc.so.6()(64bit) libdraco.so.9()(64bit) libf3d.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libvtkCommonCore.so.1()(64bit) libvtkCommonDataModel.so.1()(64bit) libvtkCommonExecutionModel.so.1()(64bit) libvtkCommonMath.so.1()(64bit) libvtkCommonSystem.so.1()(64bit) libvtkCommonTransforms.so.1()(64bit) libvtkFiltersCore.so.1()(64bit) libvtkFiltersGeneral.so.1()(64bit) libvtkFiltersGeometry.so.1()(64bit) libvtkIOCityGML.so.1()(64bit) libvtkIOExodus.so.1()(64bit) libvtkIOGeometry.so.1()(64bit) libvtkIOImage.so.1()(64bit) libvtkIOImport.so.1()(64bit) libvtkIOPLY.so.1()(64bit) libvtkIOParallel.so.1()(64bit) libvtkIOXML.so.1()(64bit) libvtkImagingCore.so.1()(64bit) libvtkImagingHybrid.so.1()(64bit) libvtkInteractionStyle.so.1()(64bit) libvtkInteractionWidgets.so.1()(64bit) libvtkRenderingAnnotation.so.1()(64bit) libvtkRenderingCore.so.1()(64bit) libvtkRenderingOpenGL2.so.1()(64bit) libvtkRenderingVolumeOpenGL2.so.1()(64bit) libvtksys.so.1()(64bit) rtld(GNU_HASH) shared-mime-info f3d-devel (rpmlib, GLIBC filtered): cmake-filesystem(aarch-64) f3d(aarch-64) libf3d.so.2()(64bit) f3d-python3 (rpmlib, GLIBC filtered): f3d(aarch-64) ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libf3d.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) python(abi) rtld(GNU_HASH) f3d-java (rpmlib, GLIBC filtered): f3d(aarch-64) javapackages-tools ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libf3d.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) rtld(GNU_HASH) f3d-debuginfo (rpmlib, GLIBC filtered): f3d-debugsource (rpmlib, GLIBC filtered): Provides -------- f3d: application() application(f3d-plugin-alembic.desktop) application(f3d-plugin-assimp.desktop) application(f3d-plugin-draco.desktop) application(f3d-plugin-exodus.desktop) application(f3d-plugin-native.desktop) application(f3d-plugin-occt.desktop) application(f3d.desktop) f3d f3d(aarch-64) libf3d-plugin-alembic.so()(64bit) libf3d-plugin-assimp.so()(64bit) libf3d-plugin-draco.so()(64bit) libf3d-plugin-exodus.so()(64bit) libf3d-plugin-occt.so()(64bit) libf3d.so.2()(64bit) metainfo() metainfo(app.f3d.F3D.metainfo.xml) mimehandler(application/dicom) mimehandler(application/gml+xml) mimehandler(application/vnd.3ds) mimehandler(application/vnd.abc) mimehandler(application/vnd.brep) mimehandler(application/vnd.dae) mimehandler(application/vnd.drc) mimehandler(application/vnd.exodus) mimehandler(application/vnd.fbx) mimehandler(application/vnd.mhd) mimehandler(application/vnd.nrrd) mimehandler(application/vnd.off) mimehandler(application/vnd.ply) mimehandler(application/vnd.pts) mimehandler(application/vnd.step) mimehandler(application/vnd.vti) mimehandler(application/vnd.vtk) mimehandler(application/vnd.vtm) mimehandler(application/vnd.vtp) mimehandler(application/vnd.vtr) mimehandler(application/vnd.vts) mimehandler(application/vnd.vtu) mimehandler(application/vnd.x) mimehandler(application/x-tgif) mimehandler(image/vnd.dxf) mimehandler(model/3mf) mimehandler(model/gltf+json) mimehandler(model/gltf-binary) mimehandler(model/iges) mimehandler(model/obj) mimehandler(model/stl) mimehandler(model/vrml) f3d-devel: cmake(f3d) f3d-devel f3d-devel(aarch-64) f3d-python3: f3d-python3 f3d-python3(aarch-64) python3-f3d f3d-java: f3d-java f3d-java(aarch-64) libf3d-java.so()(64bit) f3d-debuginfo: debuginfo(build-id) f3d-debuginfo f3d-debuginfo(aarch-64) libf3d-plugin-alembic.so-2.3.0-1.fc41.aarch64.debug()(64bit) libf3d-plugin-assimp.so-2.3.0-1.fc41.aarch64.debug()(64bit) libf3d-plugin-draco.so-2.3.0-1.fc41.aarch64.debug()(64bit) libf3d-plugin-exodus.so-2.3.0-1.fc41.aarch64.debug()(64bit) libf3d-plugin-occt.so-2.3.0-1.fc41.aarch64.debug()(64bit) libf3d.so.2.3-2.3.0-1.fc41.aarch64.debug()(64bit) f3d-debugsource: f3d-debugsource f3d-debugsource(aarch-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2193288 Buildroot used: fedora-rawhide-aarch64 Active plugins: Python, Java, Generic, C/C++, Shell-api Disabled plugins: fonts, SugarActivity, Perl, Ocaml, R, PHP, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Should https://github.com/f3d-app/f3d/blob/master/java/CMakeLists.txt be modfied so that %files java %{_libdir}/libf3d-java.so %{_javadir}/f3d.jar becomes %files java %{_libdir}/f3d/libf3d-java.so %{_jnidir}/f3d.jar which moves the internal library out if LD_LIBRARY_PATH and ues JNI install location: https://docs.fedoraproject.org/en-US/java-packaging-howto/directory_layout/ b) ownership warnings seem like an error in the review tool c) Builds on all architectures: https://koji.fedoraproject.org/koji/taskinfo?taskID=115431161 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2193288 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202193288%23c19 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
