Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: obex-data-server - a D-Bus service for Obex access https://bugzilla.redhat.com/show_bug.cgi?id=428972 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-01-20 22:32 EST ------- Review: + package builds in mock (rawhide i386). - rpmlint is silent for SRPM But NOT for RPM. obex-data-server.i386: W: conffile-without-noreplace-flag /etc/dbus-1/system.d/obex-data-server.conf ==> Ok + source files match upstream url though got different checksum Packaged tarball => 765b49276d3f21858cdf7d29f301ae48 obex-data-server-16012007.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + Compiler flags used correctly. + defattr usage is correct. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package obex-data-server-0.01-5.16012007.fc9 => Provides: config(obex-data-server) = 0.01-5.16012007.fc9 Requires: config(obex-data-server) = 0.01-5.16012007.fc9 libbluetooth.so.2 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdbus-1.so.3 libdbus-glib-1.so.2 libglib-2.0.so.0 libgobject-2.0.so.0 libopenobex.so.1 libusb-0.1.so.4 + Not a GUI APP. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review