https://bugzilla.redhat.com/show_bug.cgi?id=2254927 --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. TODO: Remove a trailing slash from the URL tag value. Source0 archive (SHA512: 324255b6a6c625d5e92d39b464bc46c34c6a3f1d7f8a837863fc98daf0aa367fb57a89b9e4940e1b3f7c923ecae90576e8fd2d479e0eea67a691ba60a25983e3) is original. Ok. Summary verified from lib/Future/Mojo.pm. Ok. Description verified from lib/Future/Mojo.pm. Ok. License found in the sources: Artistic-2.0: README, LICENSE, dist.ini, lib/Future/Mojo.pm, lib/Future/Role/Promisify.pm. "Based on CC0-1.0": CONTRIBUTING.md Note: I will handle CONTRIBUTING.md as licensed under Artistic-2.0 since "Based on CC0-1.0" does not imply CC0-1.0. I hope my interpretation is correct. Otherwise, that file should be stripped from the sources archive because Fedora does on accept CC0-1.0 for a documentation. License is Ok. No XS code, noarch BuildArch is Ok. TODO: Build-require "perl(:VERSION) >= 5.10.1" (Build.PL:21). FIX: Do not build-require "perl(Module::Build)". It's not (directly) used if "perl(Module::Build::Tiny) >= 0.034" is available. TODO: Constrain "perl(IO::Async::Loop)" dependency with ">= 0.56" (t/promisify.t:63). TODO: Constrain "perl(IO::Async::Loop::Mojo)" dependency with ">= 0.04" (t/promisify.t:63). All tests pass. Ok. $ rpmlint perl-Future-Mojo.spec ../SRPMS/perl-Future-Mojo-1.002-4.fc41.src.rpm ../RPMS/noarch/perl-Future-Mojo-1.002-4.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-Future-Mojo.noarch: E: spelling-error ('IOLoop', 'Summary(en_US) IOLoop -> Io Loop, Io-loop, Loop') perl-Future-Mojo.noarch: E: spelling-error ('IOLoop', '%description -l en_US IOLoop -> Io Loop, Io-loop, Loop') perl-Future-Mojo.src: E: spelling-error ('IOLoop', 'Summary(en_US) IOLoop -> Io Loop, Io-loop, Loop') perl-Future-Mojo.src: E: spelling-error ('IOLoop', '%description -l en_US IOLoop -> Io Loop, Io-loop, Loop') === 2 packages and 1 specfiles checked; 4 errors, 0 warnings, 6 filtered, 4 badness; has taken 0.4 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Future-Mojo-1.002-4.fc41.noarch.rpm drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/doc/perl-Future-Mojo -rw-r--r-- 1 root root 4461 Jun 16 2021 /usr/share/doc/perl-Future-Mojo/CONTRIBUTING.md -rw-r--r-- 1 root root 784 Jun 16 2021 /usr/share/doc/perl-Future-Mojo/Changes -rw-r--r-- 1 root root 2600 Jun 16 2021 /usr/share/doc/perl-Future-Mojo/README drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/licenses/perl-Future-Mojo -rw-r--r-- 1 root root 9037 Jun 16 2021 /usr/share/licenses/perl-Future-Mojo/LICENSE -rw-r--r-- 1 root root 1858 Mar 8 01:00 /usr/share/man/man3/Future::Mojo.3pm.gz -rw-r--r-- 1 root root 1841 Mar 8 01:00 /usr/share/man/man3/Future::Role::Promisify.3pm.gz -rw-r--r-- 1 root root 4244 Jun 16 2021 /usr/share/perl5/vendor_perl/Future/Mojo.pm drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/perl5/vendor_perl/Future/Role -rw-r--r-- 1 root root 2600 Jun 16 2021 /usr/share/perl5/vendor_perl/Future/Role/Promisify.pm TODO: Do not package CONTRIBUTING.md. It assumes you already have the sources available. This is not the case of a binary package. And if you obtain a source package, then you have CONTRIBUTING.md there. Moreover, that file does not bring any helpful information for using the packaged software. TODO: Package %{perl_vendorlib}/Future directory. $ rpm -q --requires -p ../RPMS/noarch/perl-Future-Mojo-1.002-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(Carp) 1 perl(Future) 1 perl(Mojo::IOLoop) 1 perl(Mojo::Promise) 1 perl(parent) 1 perl(Role::Tiny) 1 perl(Role::Tiny::With) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Constrain "perl(Future)" with ">= 0.36" (META.json:44). TODO: Constrain "perl(Role::Tiny)" with ">= 2.000002" (META.json:45). FIX: Run-require "perl-Mojolicious >= 7.54" or "perl(Mojolicious) >= 7.54" (META.json:45). That module is not directly used, but it's the only versioned module in perl-Mojolicious RPM package. The minimal version is required because of perl(Mojo::IOLoop) and perl(Mojo::Promise) which are unversioned. $ rpm -q --provides -p ../RPMS/noarch/perl-Future-Mojo-1.002-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(Future::Mojo) = 1.002 1 perl(Future::Role::Promisify) = 1.002 1 perl-Future-Mojo = 1.002-4.fc41 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Future-Mojo-1.002-4.fc41.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=115241331). Ok. TODO: Consider upgrading the package the the latest upstream release (1.003). Otherwise the package in line with Fedora and Perl packaging guidelines. Please correct the FIX items, consider fixing the TODO items and provide an updated spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2254927 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254927%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
