https://bugzilla.redhat.com/show_bug.cgi?id=2254929 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. TODO: Remove a trailing slash from URL tag. Source0 archive (SHA512: e853c34f4d8ea1a325a48674d0183442f812ee3d9170d31c46a2e4fe1b90e39e9d47c853fcccbe173aad92589f9deff0f724fe8a2b0568661e2c56b2e67c0f1b) is original. Ok. TODO: Remove deprecated "Group" tag from the spec file. Summary verified from lib/HTTP/Tiny/Paranoid.pm. Ok. Description verified from lib/HTTP/Tiny/Paranoid.pm. Ok. License verified from README, LICENSE, lib/HTTP/Tiny/Paranoid.pm, Makefile.PL, and dist.ini. Ok. No XS code, noarch BuildArch is Ok. FIX: Do not build-require run-time dependencies (e.g. "perl(Class::Method::Modifiers)") of code in ./lib. The code is not executed at build time because of no tests. Alternatively, add "perl -c blib/lib/HTTP/Tiny/Paranoid.pm" to %check section to test that the code compiles. $ rpmlint perl-HTTP-Tiny-Paranoid.spec ../SRPMS/perl-HTTP-Tiny-Paranoid-0.07-4.fc41.src.rpm ../RPMS/noarch/perl-HTTP-Tiny-Paranoid-0.07-4.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 === 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-HTTP-Tiny-Paranoid-0.07-4.fc41.noarch.rpm drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/doc/perl-HTTP-Tiny-Paranoid -rw-r--r-- 1 root root 542 Oct 30 2017 /usr/share/doc/perl-HTTP-Tiny-Paranoid/Changes -rw-r--r-- 1 root root 361 Oct 30 2017 /usr/share/doc/perl-HTTP-Tiny-Paranoid/README drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/licenses/perl-HTTP-Tiny-Paranoid -rw-r--r-- 1 root root 18352 Oct 30 2017 /usr/share/licenses/perl-HTTP-Tiny-Paranoid/LICENSE -rw-r--r-- 1 root root 1708 Mar 8 01:00 /usr/share/man/man3/HTTP::Tiny::Paranoid.3pm.gz -rw-r--r-- 1 root root 2734 Oct 30 2017 /usr/share/perl5/vendor_perl/HTTP/Tiny/Paranoid.pm TODO: Own %{perl_vendorlib}/HTTP and %{perl_vendorlib}/HTTP/Tiny directories. The directories could disappear if perl-HTTP-Tiny became architecture-specific. $ rpm -q --requires -p ../RPMS/noarch/perl-HTTP-Tiny-Paranoid-0.07-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(Class::Method::Modifiers) 1 perl(HTTP::Tiny) >= 0.070 1 perl(Net::DNS::Paranoid) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-HTTP-Tiny-Paranoid-0.07-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(HTTP::Tiny::Paranoid) = 0.07 1 perl-HTTP-Tiny-Paranoid = 0.07-4.fc41 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-HTTP-Tiny-Paranoid-0.07-4.fc41.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=115238845). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Before building this package, please correct the FIX item and consider fixing the TODO items. This package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2254929 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254929%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
