https://bugzilla.redhat.com/show_bug.cgi?id=2270340 Adam Williamson <awilliam@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |Unretirement --- Comment #1 from Adam Williamson <awilliam@xxxxxxxxxx> --- rpmlint output: [adamw@xps13a pan (rawhide *%)]$ rpmlint pan.spec =================================================================================== rpmlint session starts ================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 ============================================== 0 packages and 1 specfiles checked; 0 errors, 0 warnings, 1 filtered, 0 badness; has taken 0.1 s ============================================= [adamw@xps13a pan (rawhide *%)]$ rpml rpmlint rpmls rpmlua [adamw@xps13a pan (rawhide *%)]$ rpmlint pan-0.155-4.fc41.src.rpm =================================================================================== rpmlint session starts ================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 pan.src: E: spelling-error ('killfiles', '%description -l en_US killfiles -> kill files, kill-files, skillfulness') pan.src: E: spelling-error ('yEnc', '%description -l en_US yEnc -> y Enc, yen, enc') ============================================== 1 packages and 0 specfiles checked; 2 errors, 0 warnings, 4 filtered, 2 badness; has taken 0.1 s ============================================= the spelling errors are obviously false positives. Fun fact: this package is so old there is no original review ticket! the diff to the last pre-retirement version of the spec is: diff --git a/pan.spec b/pan.spec index 3dca50a..242bf8b 100644 --- a/pan.spec +++ b/pan.spec @@ -1,12 +1,14 @@ Summary: A Usenet newsreader for GNOME/GTK+ Name: pan -Version: 0.149 +Version: 0.155 Release: 4%{?dist} Epoch: 1 License: GPLv2 -Source0: http://pan.rebelbase.com/download/releases/%{version}/source/%{name}-%{version}.tar.bz2 +Source0: https://gitlab.gnome.org/GNOME/%{name}/-/archive/v%{version}/%{name}-v%{version}.tar.gz URL: http://pan.rebelbase.com/ -BuildRequires: make +BuildRequires: autoconf +BuildRequires: automake +BuildRequires: make BuildRequires: gcc-c++ BuildRequires: desktop-file-utils BuildRequires: gettext-devel @@ -36,11 +38,12 @@ newsreader to get a perfect score on the Good Net-Keeping Seal of Approval evaluations. %prep -%setup -q +%autosetup -p1 -n %{name}-v%{version} sed -i -e 's|StartupNotify=false|StartupNotify=true|' org.gnome.%{name}.desktop.in %build +autoreconf -i %configure --with-gtk3 --with-gnutls \ --with-dbus --with-gmime-crypto \ --with-gtkspell --enable-libnotify \ @@ -49,7 +52,7 @@ sed -i -e 's|StartupNotify=false|StartupNotify=true|' org.gnome.%{name}.desktop. make %{?_smp_mflags} %install -make DESTDIR=%{buildroot} install +%make_install %find_lang %{name} --with-gnome @@ -68,6 +71,9 @@ desktop-file-validate %{buildroot}%{_datadir}/applications/org.gnome.%{name}.des %{_mandir}/man1/pan.1* %changelog +* Tue Mar 19 2024 Adam Williamson <awilliam@xxxxxxxxxx> - 1:0.155-4 +- Update to version 0.155 + * Thu Jan 19 2023 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1:0.149-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild The 0.155 release is tagged in gitlab, but not uploaded to rebelbase.com or gnome.org, so getting it out of gitlab seems to be the only option. It looks like the next release will allow building with cmake (so we can skip autoreconf), but that's not in 0.155. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2270340 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202270340%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
