https://bugzilla.redhat.com/show_bug.cgi?id=2265862 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #7 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > Group: Applications Not used in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > Source0: https://www.tarsnap.com/spiped/spiped-1.6.2.tgz This makes it necessary to update the URL every time you bump the package to a new version. Consider using the %{version} macro as part of the URL. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_version > Patch0: install.patch Please add a comment describing what the patch does. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_patch_guidelines > %check > %{__make} test Using macro forms of system executables is discouraged. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros > %files > %{_mandir}/man1/spipe.1.gz > %{_mandir}/man1/spiped.1.gz Do not assume man pages will be gzipped. Use a wildcard that can match any compression format (including no compression). https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2265862 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202265862%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
