[Bug 2266544] Review Request: trunk - Build, bundle & ship your Rust WASM application to the web

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2266544



--- Comment #17 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
(In reply to Jens Reimann from comment #16)
> Ok, I uploaded a newer version. Working those additional comments: dropping
> crate and crate_version. I wanted to keep the latter originally. Then again
> it might bet better to stick to released versions.

Sounds good to me.

> > > trunk.x86_64: W: no-manual-page-for-binary trunk
> > 
> > I don't think upstream provides a manual page?
> 
> True, there is no man page.

Then not shipping one is fine. :)

> As for the other two, I don't know. Sounds reasonable.
> 
> > PS: When importing the package, please take care to import the spec file that is *unmodified* by rpmautospec (i.e. without preamble and with %autochangelog as the only entry under %changelog).
> 
> Meaning, the original authored file?

Yes, the one *not* included in the SRPM that is generated by "fedpkg srpm"
(i.e. the one without "GENERATED BY rpmautpspec" stuff).


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2266544

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202266544%23c17
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux