https://bugzilla.redhat.com/show_bug.cgi?id=2254931 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. TODO: Remove a trailing slash from URL. Source0 archive (SHA-512: 593b32c42e13203f1b569e1d3e8ac50d8c95a7f37ab59881fea3d588b3590b527e5319aa69668924fa1decd892b5a5bfb1f38d370ec74227c9eff46c971d8a80) is original. Ok. Summary verified from lib/Net/Async/HTTP.pm. Ok. Description verified from lib/Net/Async/HTTP.pm. Ok. License verified from Build.PL, LICENSE, lib/Net/Async/HTTP.pm, lib/Net/Async/HTTP/Connection.pm, and lib/Net/Async/HTTP/StallTimer.pm. Ok. No XS code, noarch BuildArch is Ok. TOOD: Guard the circular "perl(Net::Async::HTTP::Server)" dependency with %{defined: perl_bootstrap} condition and temporarily "%define perl_boostrap 1" at the beginning of the spec file. In Fedora Perl we strive for always bootstrapable Perl stack. TODO: Constrain the perl(Net::Async::HTTP::Server)" dependency with ">= 0.06" (t/81cross-https.t:13). TODO: Constrain "perl(Test::Pod)" dependency with ">= 1.00" (t/99pod.t). TODO: Unset NET_ASYNC_HTTP_MAXCONNS environment variable in %check section (lib/Net/Async/HTTP.pm:15). All tests pass. Ok. $ rpmlint perl-Net-Async-HTTP.spec ../SRPMS/perl-Net-Async-HTTP-0.49-4.fc41.src.rpm ../RPMS/noarch/perl-Net-Async-HTTP-0.49-4.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 === 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Net-Async-HTTP-0.49-4.fc41.noarch.rpm drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/doc/perl-Net-Async-HTTP -rw-r--r-- 1 root root 13283 Jun 6 2023 /usr/share/doc/perl-Net-Async-HTTP/Changes -rw-r--r-- 1 root root 20268 Jun 6 2023 /usr/share/doc/perl-Net-Async-HTTP/README drwxr-xr-x 2 root root 0 Jun 6 2023 /usr/share/doc/perl-Net-Async-HTTP/examples -rwxr-xr-x 1 root root 834 Jun 6 2023 /usr/share/doc/perl-Net-Async-HTTP/examples/GET.pl -rwxr-xr-x 1 root root 3040 Jun 6 2023 /usr/share/doc/perl-Net-Async-HTTP/examples/PUT.pl -rw-r--r-- 1 root root 5458 Jun 6 2023 /usr/share/doc/perl-Net-Async-HTTP/examples/parallel-put.pl drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/licenses/perl-Net-Async-HTTP -rw-r--r-- 1 root root 18413 Jun 6 2023 /usr/share/licenses/perl-Net-Async-HTTP/LICENSE -rw-r--r-- 1 root root 8158 Mar 8 01:00 /usr/share/man/man3/Net::Async::HTTP.3pm.gz -rw-r--r-- 1 root root 984 Mar 8 01:00 /usr/share/man/man3/Net::Async::HTTP::Connection.3pm.gz drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/perl5/vendor_perl/Net/Async/HTTP -rw-r--r-- 1 root root 41538 Mar 8 01:00 /usr/share/perl5/vendor_perl/Net/Async/HTTP.pm -rw-r--r-- 1 root root 18804 Mar 8 01:00 /usr/share/perl5/vendor_perl/Net/Async/HTTP/Connection.pm -rw-r--r-- 1 root root 681 Mar 8 01:00 /usr/share/perl5/vendor_perl/Net/Async/HTTP/StallTimer.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Net-Async-HTTP-0.49-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(:VERSION) >= 5.14.0 1 perl(base) 1 perl(Carp) 1 perl(constant) 1 perl(Future) >= 0.28 1 perl(Future::Utils) >= 0.16 1 perl(HTTP::Request) 1 perl(HTTP::Request::Common) 1 perl(HTTP::Response) 1 perl(IO::Async::Loop) >= 0.59 1 perl(IO::Async::Notifier) 1 perl(IO::Async::Stream) >= 0.59 1 perl(IO::Async::Timer::Countdown) 1 perl(List::Util) >= 1.29 1 perl(Metrics::Any) >= 0.05 1 perl(Net::Async::HTTP::Connection) 1 perl(Net::Async::HTTP::StallTimer) 1 perl(Scalar::Util) 1 perl(Socket) >= 2.010 1 perl(Struct::Dumb) >= 0.07 1 perl(Time::HiRes) 1 perl(URI) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --recommends -p ../RPMS/noarch/perl-Net-Async-HTTP-0.49-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(Compress::Bzip2) 1 perl(Compress::Raw::Zlib) 1 perl(IO::Async::SSL) 1 perl(Net::Async::SOCKS) TODO: Constrain "perl(Compress::Raw::Zlib)" Recommends with ">= 2.057"(META.json:32). TODO: Constrain "perl(Net::Async::SOCKS)" dependency with ">= 0.003" (lib/Net/Async/HTTP.pm:437). TODO: Constrain "perl(Compress::Bzip2)" Recommends with ">= 2.010" (lib/Net/Async/HTTP.pm:1306). TODO: Constrain "perl(IO::Async::SSL)" Recommends with ">= 0.12" (lib/Net/Async/HTTP.pm:445). $ rpm -q --provides -p ../RPMS/noarch/perl-Net-Async-HTTP-0.49-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(Net::Async::HTTP) = 0.49 1 perl(Net::Async::HTTP::Connection) = 0.49 1 perl(Net::Async::HTTP::StallTimer) = 0.49 1 perl-Net-Async-HTTP = 0.49-4.fc41 Binary provides are Ok, The package builds in Fedora Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=114944060). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. The package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2254931 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254931%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
