https://bugzilla.redhat.com/show_bug.cgi?id=2254924 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |perl-Net-DNS-Paranoid - |perl-Net-DNS-Paranoid - |Paranoid dns resolver |Paranoid DNS resolver Flags|fedora-review? |fedora-review+ --- Comment #6 from Petr Pisar <ppisar@xxxxxxxxxx> --- Changes in the spec file: --- perl-Net-DNS-Paranoid.spec.old 2024-03-08 01:00:00.000000000 +0100 +++ perl-Net-DNS-Paranoid.spec 2024-03-13 01:00:00.000000000 +0100 @@ -1,26 +1,36 @@ +# some tests require Internet access, don't enable by default +%bcond network_tests 0 + Name: perl-Net-DNS-Paranoid Version: 0.09 -Release: 1%{?dist} -Summary: Paranoid dns resolver +Release: 2%{?dist} +Summary: Paranoid DNS resolver License: GPL-1.0-or-later OR Artistic-1.0-Perl URL: https://metacpan.org/dist/Net-DNS-Paranoid/ Source0: https://cpan.metacpan.org/authors/id/T/TO/TOKUHIROM/Net-DNS-Paranoid-%{version}.tar.gz BuildArch: noarch BuildRequires: perl-interpreter perl-generators coreutils +BuildRequires: perl(:VERSION) >= 5.8.8 BuildRequires: perl(Class::Accessor::Lite) >= 0.05 BuildRequires: perl(Module::Build::Tiny) >= 0.035 BuildRequires: perl(Net::DNS) >= 0.68 -BuildRequires: perl(Net::DNS::Resolver) +# version req isn't added by RPM auto-dep +Requires: perl(Net::DNS) >= 0.68 BuildRequires: perl(Test::More) >= 0.98 +BuildRequires: perl(strict) +BuildRequires: perl(warnings) +%if %{with network_tests} +BuildRequires: perl(Net::DNS::Resolver) BuildRequires: perl(lib) BuildRequires: perl(parent) -BuildRequires: perl(strict) BuildRequires: perl(utf8) -BuildRequires: perl(warnings) +%endif %description This is a wrapper module for Net::DNS. +This module detects IP address / host names for internal servers. + %prep %setup -q -n Net-DNS-Paranoid-%{version} @@ -33,8 +43,11 @@ %{_fixperms} %{buildroot}/* %check -# tests require Internet access -%{?_with_network_tests: ./Build test} +unset VERBOSE +%if %{without network_tests} +rm t/01_simple.t +%endif +./Build test %files %doc Changes README.md @@ -43,6 +56,9 @@ %{_mandir}/man3/Net::DNS::Paranoid* %changelog +* Wed Mar 13 2024 Chris Adams <linux@xxxxxxxxxxx> 0.09-2 +- additional spec file cleanups + * Fri Mar 08 2024 Chris Adams <linux@xxxxxxxxxxx> 0.09-1 - update to new version - additional spec file cleanups All tests pass. Ok. $ rpmlint perl-Net-DNS-Paranoid.spec ../SRPMS/perl-Net-DNS-Paranoid-0.09-2.fc41.src.rpm ../RPMS/noarch/perl-Net-DNS-Paranoid-0.09-2.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 === 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s == rpmlint is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Net-DNS-Paranoid-0.09-2.fc41.noarch.rpm | sort -f | uniq -c 1 perl(:VERSION) >= 5.8.8 1 perl(Class::Accessor::Lite) 1 perl(Net::DNS) 1 perl(Net::DNS) >= 0.68 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Filter the under-specified "perl(Net::DNS)" run-dependency with __requires_exclude macro. $ resolvedeps rawhide ../RPMS/noarch/perl-Net-DNS-Paranoid-0.09-2.fc41.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=114930964). Ok. Please consider fixing the TODO item before building this package. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2254924 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254924%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
