https://bugzilla.redhat.com/show_bug.cgi?id=2269042 --- Comment #5 from Dalton Miner <daltonminer@xxxxxxxxx> --- (In reply to Neal Gompa from comment #3) > (In reply to Dalton Miner from comment #2) > > Notes: > > * libfetch is vendored into the source tree. Should this be packaged and > > depended on, or is this not the kind of bundling that's a problem? > > If it was not modified for apk-tools' usage, it could have been. I will talk > to upstream about what their plans are for apk3. Thanks! I see that it's included as a bundled provides now. > > * apk-tools does run, but fails on most operations without a database. > > Expected? > > Yes, this is expected. apt+dpkg and pacman similarly fail. Ok, fair enough. > > * Technically upstream does provide tests, but only a very basic smoke test. > > Could be included in %check if possible. > > I've added a check section to run the tests. Nice! Ok, that's all the concerns I had. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2269042 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202269042%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
