https://bugzilla.redhat.com/show_bug.cgi?id=2254924 --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-512: 8feeb038bb9ad628fee77a8a6f6a62d4a1d25f1eff22cbca3e333a9643eee2046d31dc330e62901a21bb61093ec299ab1ab8b96ed5d72d5a1667ab15c33fa4f1) is original. Ok. Summary verified from lib/Net/DNS/Paranoid.pm. Ok. TODO: Capitalize "dns" in the summary. TODO: The one-line description "wrapper module for Net::DNS" is not much helpful. Please the other line from Net::DNS::Paranoid POD, which explains the added value. License verified from LICENSE, README.md, META.json, and lib/Net/DNS/Paranoid.pm. Ok. No XS code is present, noarch BuildArch is Ok. TODO: Build-require "perl(:VERSION) >= 5.8.8" (lib/Net/DNS/Paranoid.pm:4). TODO: Unset "VERBOSE" variable in %check section. It is used in the tests (t/MockResolver.pm:27). FIX: The %{_with_network_tests} condition affects t/00_compile.t. That test does not use the Internet and should be performed regardless the condition. I instead recommend deleting t/01_simple.t in %prep section based on negation of the condition. FIX: With the %{_with_network_tests} condition as it is now, no tests are run, thus many of the BuildRequires (e.g. perl(lib), or perl(Net::DNS::Resolver)) are not needed. Guard them with the condition either. TODO: Properly declare the %{_with_network_tests} build condition with "%bcond_with network_tests". It makes the build condition discoverable. $ rpmlint perl-Net-DNS-Paranoid.spec ../SRPMS/perl-Net-DNS-Paranoid-0.09-1.fc41.src.rpm ../RPMS/noarch/perl-Net-DNS-Paranoid-0.09-1.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 === 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s == rpmlint is OK. $ rpm -q -lv -p ../RPMS/noarch/perl-Net-DNS-Paranoid-0.09-1.fc41.noarch.rpm drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/doc/perl-Net-DNS-Paranoid -rw-r--r-- 1 root root 1113 Feb 6 06:59 /usr/share/doc/perl-Net-DNS-Paranoid/Changes -rw-r--r-- 1 root root 2323 Feb 6 06:59 /usr/share/doc/perl-Net-DNS-Paranoid/README.md drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/licenses/perl-Net-DNS-Paranoid -rw-r--r-- 1 root root 18452 Feb 6 06:59 /usr/share/licenses/perl-Net-DNS-Paranoid/LICENSE -rw-r--r-- 1 root root 1923 Mar 8 01:00 /usr/share/man/man3/Net::DNS::Paranoid.3pm.gz -rw-r--r-- 1 root root 8377 Feb 6 06:59 /usr/share/perl5/vendor_perl/Net/DNS/Paranoid.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Net-DNS-Paranoid-0.09-1.fc41.noarch.rpm | sort -f | uniq -c 1 perl(:VERSION) >= 5.8.8 1 perl(Class::Accessor::Lite) 1 perl(Net::DNS) 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Constrain "perl(Net::DNS)" with ">= 0.68" (META.json:51). $ rpm -q --provides -p ../RPMS/noarch/perl-Net-DNS-Paranoid-0.09-1.fc41.noarch.rpm | sort -f | uniq -c 1 perl(Net::DNS::Paranoid) = 0.09 1 perl-Net-DNS-Paranoid = 0.09-1.fc41 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Net-DNS-Paranoid-0.09-1.fc41.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=114852235). Ok. Otherwise, the package in line with Fedora and Perl packaging guidelines. Please correct all FIX items, consider fixing TODO items, and provide a new spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2254924 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254924%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
