[Bug 2256338] Review Request: foxi - ONNXIFI with Facebook Extension

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2256338

Tomas Tomecek <ttomecek@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|NEW                         |POST



--- Comment #7 from Tomas Tomecek <ttomecek@xxxxxxxxxx> ---
I'm on F39 and building for rawhide in mock does not work well for me. I
couldn't even use the fedora-review tool.

$ rpmlint *.rpm
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 5

foxi.src: E: unknown-key 83f22833
foxi.x86_64: E: unknown-key 83f22833
foxi-debuginfo.x86_64: E: unknown-key 83f22833
foxi-debugsource.x86_64: E: unknown-key 83f22833
foxi-devel.x86_64: E: unknown-key 83f22833
foxi.x86_64: W: no-documentation
foxi-devel.x86_64: W: no-documentation
foxi.x86_64: W: dangling-relative-symlink
/usr/lib/.build-id/5c/167b005732030d0d8456ae8c645f17ed60ae92
../../../../usr/lib64/libfoxi.so
====== 5 packages and 0 specfiles checked; 5 errors, 3 warnings, 30 filtered, 5
badness; has taken 0.5 s

the only relevant issue is the last warning about the dangling symlink; I can
see you %exclude libfoxi it in the %files section:

  %exclude %{_libdir}/libfoxi.so

should the symlink be removed as well?

I went through all the MUST and SHOULD items manually since fedora-review
doesn't work for me and all passed.
The issue with the symlink doesn't seem blocking to me.

Approved


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2256338

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256338%23c7
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux