https://bugzilla.redhat.com/show_bug.cgi?id=2252229 Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #20 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- I think this looks good now XXX APPROVED XXX A few things to tweak before import: - please version the shared objects in the %files sections: we avoid using wildcards there so that any version bumps in shared objects get caught in builds https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files (In reply to Sandro from comment #17) > (In reply to Ankur Sinha (FranciscoD) from comment #16) <snip> > > - may need to look at whether it bundles Random123/pss (and other things?) > > Good catch. Random123 was bundled. I'm now using the system Random123. In > pss/ there's only two header files, both with an acceptable license. > Apparently pss is an acronym for parallel stable sort. I couldn't find a > suitable package in the repos. > > I think it's okay leaving it in. Not sure if I need to add a provides > bundled. Yeh, I think that's fine too. > > > - the -{openmpi,mpich}-devel sub packages should probably also Require: > > {openmpich/mpich}-devel I think, since they'll be required for development? > > Why? I haven't seen that done in any of the MPI packages I've touched so far. Hrm, we probably should update our other packages too. If someone is developing against the library's mpi variant, they'll also need to link against the mpi libraries and all that too, so they'd need to mpi-devel packages that provide the unversioned-shared objects. > I included generated man pages now for the binaries of the standard package > where it makes (kind of) sense. Unfortunately, most of the binaries do not > implement `--help` throwing errors regarding missing or unknown arguments. > Some even dump core. > > I'm not sure it makes sense at all. But I left it in for now so you can see > for yourself. Ugh, that's unfortunate. If they error and don't produce usable man pages it's better to skip them. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2252229 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202252229%23c20 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
