https://bugzilla.redhat.com/show_bug.cgi?id=2254915 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Petr Pisar <ppisar@xxxxxxxxxx> --- Differences in the spec file: --- perl-Filter-signatures.spec.old 2024-02-01 01:00:00.000000000 +0100 +++ perl-Filter-signatures.spec 2024-03-11 17:32:52.000000000 +0100 @@ -1,12 +1,15 @@ Name: perl-Filter-signatures Version: 0.19 -Release: 3%{?dist} +Release: 4%{?dist} Summary: Very simplistic signatures for Perl < 5.20 License: GPL-1.0-or-later OR Artistic-1.0-Perl URL: https://metacpan.org/dist/Filter-signatures/ Source0: https://cpan.metacpan.org/authors/id/C/CO/CORION/Filter-signatures-%{version}.tar.gz BuildArch: noarch BuildRequires: make perl-interpreter perl-generators coreutils +BuildRequires: perl(:VERSION) >= 5.6 +# needed for TAP::Harness +BuildRequires: perl(CPAN::Meta::YAML) BuildRequires: perl(Data::Dumper) BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 BuildRequires: perl(Filter::Simple) >= 0.91 @@ -39,15 +42,22 @@ %{_fixperms} %{buildroot}/* %check +# make sure tests run correctly +unset FORCE_FILTER_SIGNATURES make test %files %doc Changes README -%license LICENSE -%{perl_vendorlib}/* -%{_mandir}/man3/* +# note: files all say perl_5 which is GPLv1/Artistic but file is Artistic-2 +# https://github.com/Corion/filter-signatures/issues/4 +#%license LICENSE +%{perl_vendorlib}/Filter +%{_mandir}/man3/Filter::signatures* %changelog +* Mon Mar 11 2024 Chris Adams <linux@xxxxxxxxxxx> 0.19-4 +- additional spec file cleanups + * Thu Feb 01 2024 Chris Adams <linux@xxxxxxxxxxx> 0.19-3 - additional spec file cleanups $ rpmlint perl-Filter-signatures.spec ../SRPMS/perl-Filter-signatures-0.19-4.fc41.src.rpm ../RPMS/noarch/perl-Filter-signatures-0.19-4.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-Filter-signatures.spec:53: W: macro-in-comment %license perl-Filter-signatures.spec:53: W: macro-in-comment %license === 2 packages and 1 specfiles checked; 0 errors, 2 warnings, 6 filtered, 0 badness; has taken 0.4 s == FIX: Escape the per-cent character at "%license" in the comment. The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=114841474). Ok. Please correct the FIX item before building this package. The package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2254915 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254915%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
