https://bugzilla.redhat.com/show_bug.cgi?id=2266544 --- Comment #10 from Jens Reimann <jreimann@xxxxxxxxxx> --- Thanks again for the review. I like the idea of having the package named `trunk`, I'll be working towards that. > PS: v0.19.0 was released in the meantime. I know, that was me :) Already updated the spec file. When it comes to the positions of fields in the file, I had (still have) no idea what's the preference. I'll just move them around as you suggested. I am struggling adding the build flags to other tasks though, adding them like this: ``` %build %cargo_build %{_trunk_features} %{cargo_license_summary} %{_trunk_features} %{cargo_license} %{_trunk_features} > LICENSE.dependencies %{cargo_vendor_manifest} %{_trunk_features} ``` I'll run into this: ``` /var/tmp/rpm-tmp.rflLYE: line 58: syntax error near unexpected token `-n' error: Bad exit status from /var/tmp/rpm-tmp.rflLYE (%build) ``` Maybe it's something obvious that I miss, but I don't see it. I am using the same way as with the `%cargo_build` (and others). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2266544 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202266544%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
