https://bugzilla.redhat.com/show_bug.cgi?id=2262810 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |xavier@xxxxxxxxxxxx CC| |xavier@xxxxxxxxxxxx Status|NEW |ASSIGNED Flags| |fedora-review? --- Comment #5 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- - Add a comment about the upstream tarball missing tests - Drop '# remirepo:*' comments - The conditional : ``` %if 0%{?fedora} >= 27 || 0%{?rhel} >= 8 BuildRequires: (php-composer(%{pk_vendor}/recursion-context) >= 6.0 with php-composer(%{pk_vendor}/recursion-context) < 7) %else BuildRequires: php-sebastian-recursion-context6 %endif ``` Could be rewritten as : ``` %if %{?el7} BuildRequires: php-sebastian-recursion-context6 %else BuildRequires: (php-composer(%{pk_vendor}/recursion-context) >= 6.0 with php-composer(%{pk_vendor}/recursion-context) < 7) %endif ``` But does EL7 still carry value at this point ? - Drop `%{!?_licensedir:%global license %%doc}` in %files Otherwise looks good. Full review incoming. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2262810 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202262810%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
