https://bugzilla.redhat.com/show_bug.cgi?id=2262807 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@xxxxxxxxxxxx Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |xavier@xxxxxxxxxxxx Flags| |fedora-review? --- Comment #5 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- - In %files, please drop : # remirepo:1 %{!?_licensedir:%global license %%doc} - Add a comment about upstream tarball missing tests. - In %check, please drop # remirepo:5 - In %check, does it really make sense to support EL7 at this time ? Also, conditional could be written %{?el7} - I must admit I'm not overly fond of the bundled symfony-process, but so be it... Full review incoming... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2262807 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202262807%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
