https://bugzilla.redhat.com/show_bug.cgi?id=2264588 --- Comment #8 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #7) > Comments: > a) Builds on all architectures: > https://koji.fedoraproject.org/koji/taskinfo?taskID=114620368 > b) Upstream seems to just build the tests. Maybe some of them can also be > run? > c) Approved. Thank you for the review! The upstream tests for this particular package are strictly “include tests.” There is nothing that actually runs: the test is just whether we can include each header in the header-only library, e.g. [1], compile them, and link them together into a do-nothing executable with an empty main()[2]. So it’s really just a “does it compile and link” smoke-test, and that’s it. If upstream does add some kind of executable functional/unit tests in the future, I’ll be sure to run them. [1] https://github.com/BenHanson/parsertl17/blob/main/tests/include_test/ebnf_tables.cpp [2] https://github.com/BenHanson/parsertl17/blob/main/tests/include_test/include_test.cpp -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2264588 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202264588%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
