https://bugzilla.redhat.com/show_bug.cgi?id=2241989 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED CC| |mikel@xxxxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |mikel@xxxxxxxxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- spec has been created with go2rpm-1.9.0 and although it's correct, if you can use the go2rpm-1.11.0 template it will be better for the future. This is the diff, there are just some minimal changes: > --- golang-fortio-assert.spec.1 2023-10-03 20:36:41.000000000 +0200 > +++ golang-fortio-assert.spec 2024-03-06 20:50:45.774730132 +0100 > @@ -1,4 +1,4 @@ > -# Generated by go2rpm 1.9.0 > +# Generated by go2rpm 1.10.0 > %bcond_without check > %global debug_package %{nil} > > @@ -7,8 +7,7 @@ > %global forgeurl https://github.com/fortio/assert > Version: 1.2.0 > > -%gometa -f > > +%gometa -L -f > > %global common_description %{expand: > Minimalistic replacement for > @@ -17,7 +16,7 @@ > %global golicenses LICENSE > %global godocs README.md > > -Name: %{goname} > +Name: golang-fortio-assert > Release: %autorelease > Summary: Minimalistic replacement for stretchr/testify/assert > > @@ -30,7 +29,7 @@ > %gopkg > > %prep > -%goprep > +%goprep -A > %autopatch -p1 > > %generate_buildrequires Please, update this and the other specs to the new template if possible. I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2241989 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241989%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
