https://bugzilla.redhat.com/show_bug.cgi?id=2240617 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@xxxxxxxxxxxx --- Comment #12 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- A couple comments. - For my education, could you please explain ? ``` # For compatibility with SCL %undefine __brp_mangle_shebangs ``` - Typo : `# disabled as phpunit not availble` --> available - Add a comment explaining upstream tarball is not usable due to missing tests, etc... - In %%files, spurious line : ``` # remirepo:1 ``` - In %%files, I believe the following line has lost its purpose nowadays: ``` %{!?_licensedir:%global license %%doc} ``` - I find using ':' rather than '#' for commented lines to be confusing, but that is probably just me -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2240617 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202240617%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
