https://bugzilla.redhat.com/show_bug.cgi?id=2260290 --- Comment #12 from Jens Petersen <petersen@xxxxxxxxxx> --- > a) Thanks for th updates. Raised issue upstream about enabling index > operation from GUI Thanks > b) Do not get a segfault, so it maybe F40 and rawhide only. Perhaps try using > %configure --enable-opengl --disable-x11 > and add glfw-devel to the dependencies. This works for me on F40. Okay > c) Can the test script be run? Adding ./test.sh in the %check section fails > with file not found, but perhaps > am doing something wrong, not sure why the file is removed. I don't think you are doing anything wrong: there is no "test.sh" in the tarballs... ;o) I suppose it is only in the git repo. > If not, perhaps a smoke test ./duc -h could be added. Sure > d) Please add cairo-devel to the dependencies, it is pulled in by > pango-devel but is needed separately Okay > e) Documentation files seem to indicate GPL: > https://github.com/zevv/duc/blob/master/doc/duc.md > Made a pull request upstream Thanks! Yeah that is confusing, though the License file appears perhaps newer so I tend to agree. > f) One file seems to have Khronos license: > Khronos License > --------------- > duc-1.4.5/src/glad/KHR/khrplatform.h Is that MIT-Khronos, which has not been approved yet by SPDX? Hmm Anyway I will note it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2260290 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202260290%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
