https://bugzilla.redhat.com/show_bug.cgi?id=2267127 --- Comment #11 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #9) [...] > Comments: > > >> a) License in spec file should probably be > >> GPL-2.1-or-later AND LGPL-2.1-or-later > >> not > >> GPL-2.1-or-later > >> Maybe also add an explanation in the spec file that some plugins are > >> enabled, though the license > >> list produced > > > End of the sentence missing? Otherwise not sure what you mean above. > > Sorry, the license listing does not indicate any GPL files for anythin other > than m4 files used during the build process. Nevertheless, > it may be helpful to add an explanation in the spec file that the GPL > license is due to enabling a configuration for this. Probably upstream > should also add GPL license file to the source archive. I see what you mean. GPL license is enabled by the --enable-gpl switch, which is necessary to allow externally-built GPL plugins to work. > b) Building the documentation may be helpful. If built as html, would > suggest a separate package due to the > use of jquery and javascript. Doxygen can also generate output in other > formats, but unclear if it would be > helpful. Not a must to build the documentation though. Given how old this code is, I think it's not worth the effort. > c) lqtplay is a graphical application, so probably a desktop file is > helpful, though unclear what qualifies > as a GUI application. It's a video player with very limited capabilities (only X11 with Xvideo or OpenGL and ALSA outputs). I think it's not advisable to make it easily discoverable. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2267127 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202267127%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
