https://bugzilla.redhat.com/show_bug.cgi?id=2267127 --- Comment #6 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #5) [...] > Comments: > > a) License in spec file should probably be > GPL-2.1-or-later AND LGPL-2.1-or-later > not > GPL-2.1-or-later > Maybe also add an explanation in the spec file that some plugins are > enabled, though the license > list produced End of the sentence missing? Otherwise not sure what you mean above. > b) For the main package, perhaps add > %dir %{_libdir}/%{name} > to ensure directory ownership Sure. > c) Perhaps modify the spec file to have: > %global date 20240202 > %global commit 2213b76712c8e08d885482d117f904d570c990aa > %global shortcommit %(c=%{commit}; echo ${c:0:7}) > rather than > %define date 20240202 > %define commit 2213b76712c8e08d885482d117f904d570c990aa > %define shortcommit %(c=%{commit}; echo ${c:0:7}) Ok. > d) Does not build on s390x: > https://koji.fedoraproject.org/koji/taskinfo?taskID=114286515 > perhaps exclude the architecture, some dependencies are unavailable > DEBUG util.py:461: No match for argument: libavc1394-devel > DEBUG util.py:461: No match for argument: libraw1394-devel Fixed. > e) Should the util package explicitly require the libquicktime package to > ensure license is always installed? Added, but it'll always pull in libquicktime as a dependency, anyway. > f) Should lqtplay have a desktop file? Perhaps. Spec URL: https://rathann.fedorapeople.org/review/libquicktime/libquicktime.spec SRPM URL: https://rathann.fedorapeople.org/review/libquicktime/libquicktime-1.2.4-61.20240202git2213b76.fc41.src.rpm * Fri Mar 01 2024 Dominik Mierzejewski <dominik@xxxxxxxxxxxxxx> - 1.2.4-61.20240202git2213b76 - drop missing lib{avc,raw}1394 build dependencies on s390x - add LGPLv2.1 to License field - own _libdir/libquicktime - use global instead of define -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2267127 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202267127%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
