https://bugzilla.redhat.com/show_bug.cgi?id=2254915 --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA512 c3edc8ea4438ea9c610d813650efc1053089f4be9199cf45f6fece541c5fd77d6f99e273d9cdb210fc10c5aeb1f12338152c559cc8cbe052807d5d6fff787ff4) is original. Ok. Summary verified in lib/Filter/signatures.pm. Ok. Description verified in lib/Filter/signatures.pm. Ok. License verified in Makefile.PL, README.mkdn, lib/Filter/signatures.pm, README. Ok. Other licenses found: LICENSE: Artistic-2.0 text TODO: Ask upstream to replace the LICENSE file with Artistic-1.0-Perl text <https://dev.perl.org/licenses/artistic.html>. The current LICENSE carries a different license. No XS code, noarch BuildArch is Ok. TODO: Build-require 'perl(:VERSION) >= 5.6' (Makefile.PL:43). TODO: Unset FORCE_FILTER_SIGNATURES environment variable in %check section. A code flow of the tested library depends on it. FIX: List packaged files more explicitly <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists>. All tests pass. Ok. $ rpmlint perl-Filter-signatures.spec ../SRPMS/perl-Filter-signatures-0.19-3.fc41.src.rpm ../RPMS/noarch/perl-Filter-signatures-0.19-3.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 === 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s = rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Filter-signatures-0.19-3.fc41.noarch.rpm drwxr-xr-x 2 root root 0 Feb 1 01:00 /usr/share/doc/perl-Filter-signatures -rw-r--r-- 1 root root 4287 Jul 22 2023 /usr/share/doc/perl-Filter-signatures/Changes -rw-r--r-- 1 root root 1887 Jul 22 2023 /usr/share/doc/perl-Filter-signatures/README drwxr-xr-x 2 root root 0 Feb 1 01:00 /usr/share/licenses/perl-Filter-signatures -rw-r--r-- 1 root root 8893 Jul 22 2023 /usr/share/licenses/perl-Filter-signatures/LICENSE -rw-r--r-- 1 root root 3673 Feb 1 01:00 /usr/share/man/man3/Filter::signatures.3pm.gz drwxr-xr-x 2 root root 0 Feb 1 01:00 /usr/share/perl5/vendor_perl/Filter -rw-r--r-- 1 root root 15678 Jul 22 2023 /usr/share/perl5/vendor_perl/Filter/signatures.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Filter-signatures-0.19-3.fc41.noarch.rpm | sort -f | uniq -c 1 perl(feature) 1 perl(Filter::Simple) 1 perl(strict) 1 perl(warnings) 1 perl(warnings::register) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Constrain 'perl(Filter::Simple)' with '>= 0.91' (Makefile.PL:53). $ rpm -q --provides -p ../RPMS/noarch/perl-Filter-signatures-0.19-3.fc41.noarch.rpm | sort -f | uniq -c 1 perl(Filter::signatures) = 0.19 1 perl-Filter-signatures = 0.19-3.fc41 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Filter-signatures-0.19-3.fc41.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=114288855). Ok. Otherwise the package in line with Fedora and Perl packaging guidelines. Please consider fixing TODO items, correct the FIX item and provide a new spec file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2254915 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254915%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
