https://bugzilla.redhat.com/show_bug.cgi?id=2254914 --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA512: 9b34b43d2f1d701aeec080f09b27ece86f23dc98a282a959f1c09c432b02f9124e9916e43a840943e940a3d3b3c19c21a18208ee19c31de9ce989c25e34587d1) is original. Ok. Summary verified from lib/AnyEvent/Future.pm. Ok. Description verified from lib/AnyEvent/Future.pm. Ok. License verified from: Build.PL, lib/AnyEvent/Future.pm, LICENSE. Ok. No XS code, noarch BuildArch is Ok. TODO: Build-require 'perl(:VERSION) >= 5.14' (Build.PL:10, t/99pod.t:3). TODO: Consider removing t/99pod.t file in %prep section. A result of the tests depends on presence of Test::Pod module which is not specified among BuildRequires. That makes the test nondeterministic. FIX: List packaged files more explicitly (i.e. no /* globs) <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists>. All tests pass. Ok. $ rpmlint perl-AnyEvent-Future.spec ../SRPMS/perl-AnyEvent-Future-0.05-3.fc41.src.rpm ../RPMS/noarch/perl-AnyEvent-Future-0.05-3.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-AnyEvent-Future.noarch: E: spelling-error ('Utils', '%description -l en_US Utils -> Tills') perl-AnyEvent-Future.src: E: spelling-error ('Utils', '%description -l en_US Utils -> Tills') === 2 packages and 1 specfiles checked; 2 errors, 0 warnings, 6 filtered, 2 badness; has taken 0.3 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-AnyEvent-Future-0.05-3.fc41.noarch.rpm drwxr-xr-x 2 root root 0 Feb 1 01:00 /usr/share/doc/perl-AnyEvent-Future -rw-r--r-- 1 root root 866 Feb 3 2023 /usr/share/doc/perl-AnyEvent-Future/Changes -rw-r--r-- 1 root root 7339 Feb 3 2023 /usr/share/doc/perl-AnyEvent-Future/README drwxr-xr-x 2 root root 0 Feb 3 2023 /usr/share/doc/perl-AnyEvent-Future/examples -rw-r--r-- 1 root root 621 Feb 3 2023 /usr/share/doc/perl-AnyEvent-Future/examples/http_get.pl drwxr-xr-x 2 root root 0 Feb 1 01:00 /usr/share/licenses/perl-AnyEvent-Future -rw-r--r-- 1 root root 18413 Feb 3 2023 /usr/share/licenses/perl-AnyEvent-Future/LICENSE -rw-r--r-- 1 root root 3724 Feb 1 01:00 /usr/share/man/man3/AnyEvent::Future.3pm.gz drwxr-xr-x 2 root root 0 Feb 1 01:00 /usr/share/perl5/vendor_perl/AnyEvent -rw-r--r-- 1 root root 8870 Feb 1 01:00 /usr/share/perl5/vendor_perl/AnyEvent/Future.pm The file layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-AnyEvent-Future-0.05-3.fc41.noarch.rpm | sort -f | uniq -c 1 perl(:VERSION) >= 5.14.0 1 perl(AnyEvent) 1 perl(base) 1 perl(Exporter) 1 perl(Future) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Add '>= 0.49' constraint to 'perl(Future)' run-time dependency (META.json:25). $ rpm -q --provides -p ../RPMS/noarch/perl-AnyEvent-Future-0.05-3.fc41.noarch.rpm | sort -f | uniq -c 1 perl(AnyEvent::Future) = 0.05 1 perl-AnyEvent-Future = 0.05-3.fc41 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-AnyEvent-Future-0.05-3.fc41.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=114286416). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please consider fixing the TODO items, correct the FIX item, and provide a new spec file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2254914 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254914%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
