https://bugzilla.redhat.com/show_bug.cgi?id=2260538 Viktor Malik <vmalik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vmalik@xxxxxxxxxx --- Comment #15 from Viktor Malik <vmalik@xxxxxxxxxx> --- >From specfile: > BuildRequires: [...] libbpf How does Kepler load the BPF program? I assume it uses libbpf so libbpf should be a runtime dependency (i.e. in "Requires"), unless you're linking against it statically. On the contrary, I'd expect libbpf-devel in "BuildRequires". > New question :) - if this is platform-independent eBPF bytecode, why prefix the name with amd64? For people on other arches this is going to be a source of confusion - looking at my aarch64 laptop and my confusion RN for example ;) Agreed with Nathan here. BPF binaries are arch-independent (they are ELFs with a special "BPF" architecture) so the prefix shouldn't be there. > I believe it needs to be built locally as part of the Fedora build each time Despite being arch-independent, I agree that the binary should be rebuilt as a part of the specfile, as per Fedora guidelines. In fact, IIUC, that's exactly what > make genlibbpf _build_local GOOS=${GOOS} GOARCH=${GOARCH} ATTACHER_TAG=libbpf in the specfile does. So you just need to remove ./bpfassets/libbpf/bpf.o/amd64_kepler.bpf.o in the %prep phase, as mentioned above. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2260538 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202260538%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
