https://bugzilla.redhat.com/show_bug.cgi?id=2265851 --- Comment #9 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Ben Beasley from comment #7) > I think always using install -p is a good habit. In this case, I didn’t push > for it because these files don’t make it into the binary RPMs, so nobody > ever gets to see the timestamps anyway. I agree. Even though it doesn't matter here, I'll try to remember using -p whenever I have to install stuff myself again. > Then, I used the trick described in > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > #_troublesome_urls to make the URLs end with the filenames. That will make it into my cheat sheet. I had a small script prepared already. But with the URL manipulation, that is no longer needed. Thanks for pointing that out. (In reply to Ben Beasley from comment #8) > You don’t need to add “AND CC-BY-4.0” to the License field, since that is > supposed to represent the licenses of the binary RPMs, and none of the test > data files contribute to the binary RPMs. Right. I can fix that on import. Unless there's something else requiring an updated spec or srpm. I was also wondering if I should upload the test sources to the side cache or carry them in dist-git. Along the same reasoning as the License field, I'm inclined to add them to dist-git. The downside, though, is the size of the files - `trx_from_scratch.zip` is 25M. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2265851 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202265851%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
