https://bugzilla.redhat.com/show_bug.cgi?id=2265851 --- Comment #7 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Sandro from comment #3) > > > - If you wanted to make this more concise, > > > > mkdir tests > > install -m 644 %{SOURCE1} tests > > install -m 644 %{SOURCE2} tests > > install -m 644 %{SOURCE3} tests > > install -m 644 %{SOURCE4} tests > > > > you could write something like > > > > install -p -m 644 -D -t tests %{SOURCE1} %{SOURCE2} %{SOURCE3} %{SOURCE4} > > > > No change is required. > > I'll keep that in mind. I think the -p flag here should almost be mandatory, > according to > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps I think always using install -p is a good habit. In this case, I didn’t push for it because these files don’t make it into the binary RPMs, so nobody ever gets to see the timestamps anyway. > Wow! How did you arrive at those URLs? First, I searched for each filename at https://figshare.com to find the dataset it came from, and put the dataset URL in the comment. Then, I looked for the download link for the dataset and confirmed it matched the URL defined in the package source in trx.fetcher.get_testing_files_dict(). Then, I used the trick described in https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_troublesome_urls to make the URLs end with the filenames. Finally, I clicked “Cite” and copied the DOI URL into the comment too. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2265851 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202265851%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
