https://bugzilla.redhat.com/show_bug.cgi?id=2265851 --- Comment #3 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Ben Beasley from comment #2) > Issues: > ======= > - Dist tag is present. > > OK: fedora-review is confused by rpmautospec. > > - You might find it nicer to write > > > https://patch-diff.githubusercontent.com/raw/tee-ar-ex/trx-python/pull/75. > patch > > as > > https://github.com/tee-ar-ex/trx-python/pull/75.patch > > or > > %{forgeurl}/pull/75.patch > > since it is more succinct and more easily associated with the original > repository and PR. Agreed. I guess I was just being lazy copying and pasting URLs. ;) > - If you wanted to make this more concise, > > mkdir tests > install -m 644 %{SOURCE1} tests > install -m 644 %{SOURCE2} tests > install -m 644 %{SOURCE3} tests > install -m 644 %{SOURCE4} tests > > you could write something like > > install -p -m 644 -D -t tests %{SOURCE1} %{SOURCE2} %{SOURCE3} %{SOURCE4} > > No change is required. I'll keep that in mind. I think the -p flag here should almost be mandatory, according to https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps > - Since it’s possible to form URLs for the test sources, it would be better > to do so: > > Source1: https://figshare.com/ndownloader/files/37624154#/DSI.zip > Source2: > https://figshare.com/ndownloader/files/37624148#/memmap_test_data.zip > Source3: > https://figshare.com/ndownloader/files/37624151#/trx_from_scratch.zip > Source4: > https://figshare.com/ndownloader/files/38146098#/gold_standard.zip > > More importantly, we need to audit these files and make sure they are under > licenses that are allowed for content in Fedora. Something like this seems > reasonable: > > # https://figshare.com/articles/dataset/DSI_zip/21215549 > # https://doi.org/10.6084/m9.figshare.21215549.v1 > # CC-BY-4.0 > Source1: https://figshare.com/ndownloader/files/37624154#/DSI.zip > # https://figshare.com/articles/dataset/memmap_test_data_zip/20020460 > # https://doi.org/10.6084/m9.figshare.20020460.v2 > # CC-BY-4.0 > Source2: > https://figshare.com/ndownloader/files/37624148#/memmap_test_data.zip > # https://figshare.com/articles/dataset/trx_from_scratch_zip/20020412 > # https://doi.org/10.6084/m9.figshare.20020412.v2 > # CC-BY-4.0 > Source3: > https://figshare.com/ndownloader/files/37624151#/trx_from_scratch.zip > # https://figshare.com/articles/dataset/gold_standard_zip/21520557 > # https://doi.org/10.6084/m9.figshare.21520557.v1 > # CC-BY-4.0 > Source4: > https://figshare.com/ndownloader/files/38146098#/gold_standard.zip Wow! How did you arrive at those URLs? I added the zip archives separately mainly because of those unwieldy URLs. You are right about the license. I slipped on that, thinking they are not part of the install. But, of course, they are part of the SRPM ... -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2265851 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202265851%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
