[Bug 2266544] Review Request: rust-trunk - Build, bundle & ship your Rust WASM application to the web

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2266544



--- Comment #2 from Jens Reimann <jreimann@xxxxxxxxxx> ---
(In reply to Fabio Valentini from comment #1)
> 1. Please address the FIXMEs in the spec file.

Sorry, I overlooked that.

> 2. Don't disable the mangle_shebangs brp, fix the underlying issue (i.e.
> removing executable bits from all *.rs files).

That was a good pointer. I didn't expect that this was tied to an executable
bit on the .rs file

> I'll do a full review once these basics are addressed.

I uploaded the two files (spec, srpm) again and also triggered a new scratch
build (https://koji.fedoraproject.org/koji/taskinfo?taskID=114181652). The
local mockbuild was fine.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2266544

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202266544%23c2
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux