[Bug 2263035] Review Request: kmidimon - Drumstick MIDI monitor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2263035

Neal Gompa <ngompa13@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |ngompa13@xxxxxxxxx
                 CC|                            |ngompa13@xxxxxxxxx
             Status|NEW                         |POST



--- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> ---
Review notes:

* Packaging follows Fedora packaging guidelines
* Package builds and installs
* Package licensing is correctly recorded
* No serious issues from rpmlint

PACKAGE APPROVED.

Extra notes:

> BuildRequires:  cmake(drumstick-alsa) >= 2.9
> # transitive dependency of drumstick-alsa
> BuildRequires:  alsa-lib-devel >= 1.0

This is not required because "cmake(drumstick-alsa)" already requires
"alsa-lib-devel".


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2263035

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202263035%23c2
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux