https://bugzilla.redhat.com/show_bug.cgi?id=2257948 --- Comment #13 from Clemens Lang <cllang@xxxxxxxxxx> --- I looked through your dependency tree from a cryptographic point of view, and most of it is fine. A lot of the cryptography is implemented in rust and thus does not use one of the implementations we validate according to various standards on RHEL. This means that, for example, a system running in FIPS mode or a CommonCriteria-certified system should not make security assumptions about bpfman (i.e., whatever signatures it verifies should not be considered trusted). That's not an issue for Fedora, though. As for specific questionable algorithms that are in your vendored source tree: - You already identified p434 in the fiat-crypto crate. See [1,2,3] for reference, background discussion and patches. Maybe you can not bundle fiat-crypto and use the version from Fedora? - cruve25519-dalek contains an implementation of the Ristretto group [4,5]. I'm not aware of prior legal review of that group, so maybe we shouldn't include it. I'm also somewhat generally concerned about side-channel vulnerabilities in those cryptographic implementations. We test the common implementations on RHEL and Fedora, but not those Rust ones. We already know that some of those crates are vulnerable to side-channel attacks [6,7]. My recommendation would thus be to drop support for the p343 and Ristretto curves, and tread carefully when it comes to some of the other libraries with respect to side-channel issues. [1]: https://lists.fedoraproject.org/archives/list/legal%40lists.fedoraproject.org/thread/FBZU2X7ZKTK2BVZKBHFUCI44SMY4UQCE/ [2]: https://src.fedoraproject.org/rpms/rust-fiat-crypto/blob/rawhide/f/gen_clean_tarball.sh [3]: https://fedoraproject.org/wiki/Legal:ECC [4]: https://github.com/dalek-cryptography/curve25519-dalek/blob/curve25519-4.1.1/curve25519-dalek/src/ristretto.rs [5]: https://ristretto.group/ristretto.html [6]: https://github.com/RustCrypto/RSA/issues/19 [7]: https://github.com/RustCrypto/RSA/blob/master/src/algorithms/pkcs1v15.rs#L59-L63 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2257948 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257948%23c13 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
