https://bugzilla.redhat.com/show_bug.cgi?id=2264277 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) | --- Comment #12 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "BSD 2-Clause License", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU General Public License, Version 2", "*No copyright* BSD 2-Clause License", "*No copyright* GNU Lesser General Public License, Version 2.1". 231 files have unknown license. Detailed output of licensecheck in /home/fedora/2264277-scx_c_schedulers/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 16298 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: scx_c_schedulers-0.1.7-1.fc41.aarch64.rpm scx_c_schedulers-debuginfo-0.1.7-1.fc41.aarch64.rpm scx_c_schedulers-debugsource-0.1.7-1.fc41.aarch64.rpm scx_c_schedulers-0.1.7-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpja927uou')] checks: 32, packages: 4 scx_c_schedulers.aarch64: W: summary-not-capitalized sched_ext schedulers written in c scx_c_schedulers.src: W: summary-not-capitalized sched_ext schedulers written in c scx_c_schedulers.aarch64: E: spelling-error ('flatcg', '%description -l en_US flatcg -> flat cg, flat-cg, flatcar') scx_c_schedulers.aarch64: E: spelling-error ('qmap', '%description -l en_US qmap -> map, q map') scx_c_schedulers.aarch64: E: spelling-error ('userland', '%description -l en_US userland -> user land, user-land, slanderous') scx_c_schedulers.src: E: spelling-error ('flatcg', '%description -l en_US flatcg -> flat cg, flat-cg, flatcar') scx_c_schedulers.src: E: spelling-error ('qmap', '%description -l en_US qmap -> map, q map') scx_c_schedulers.src: E: spelling-error ('userland', '%description -l en_US userland -> user land, user-land, slanderous') scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_central scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_flatcg scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_nest scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_pair scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_qmap scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_simple scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_userland scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_central scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_flatcg scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_nest scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_pair scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_qmap scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_simple scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_userland scx_c_schedulers.aarch64: W: invalid-license LGPL-2.1 scx_c_schedulers.src: W: invalid-license LGPL-2.1 scx_c_schedulers-debuginfo.aarch64: W: invalid-license LGPL-2.1 scx_c_schedulers-debugsource.aarch64: W: invalid-license LGPL-2.1 scx_c_schedulers-debugsource.aarch64: E: files-duplicated-waste 100043 4 packages and 0 specfiles checked; 7 errors, 20 warnings, 49 filtered, 7 badness; has taken 1.5 s Rpmlint (debuginfo) ------------------- Checking: scx_c_schedulers-debuginfo-0.1.7-1.fc41.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpeyl6auae')] checks: 32, packages: 1 scx_c_schedulers-debuginfo.aarch64: W: invalid-license LGPL-2.1 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 35 filtered, 0 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 scx_c_schedulers.aarch64: W: summary-not-capitalized sched_ext schedulers written in c scx_c_schedulers.aarch64: E: spelling-error ('flatcg', '%description -l en_US flatcg -> flat cg, flat-cg, flatcar') scx_c_schedulers.aarch64: E: spelling-error ('qmap', '%description -l en_US qmap -> map, q map') scx_c_schedulers.aarch64: E: spelling-error ('userland', '%description -l en_US userland -> user land, user-land, slanderous') scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_central scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_flatcg scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_nest scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_pair scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_qmap scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_simple scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_userland scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_central scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_flatcg scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_nest scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_pair scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_qmap scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_simple scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_userland scx_c_schedulers.aarch64: W: invalid-license LGPL-2.1 scx_c_schedulers-debuginfo.aarch64: W: invalid-license LGPL-2.1 scx_c_schedulers-debugsource.aarch64: W: invalid-license LGPL-2.1 scx_c_schedulers-debugsource.aarch64: E: files-duplicated-waste 100043 3 packages and 0 specfiles checked; 4 errors, 18 warnings, 45 filtered, 4 badness; has taken 2.3 s Source checksums ---------------- https://github.com/libbpf/libbpf/archive/528cb9d3e933c2b10b152249779c2ff72efa4224/libbpf-1.4.0~^20240125git528cb9d.tar.gz : CHECKSUM(SHA256) this package : 45041039893a844772e700769c2f8adbe20b1fcfbd3520516f6768ebf69dc66a CHECKSUM(SHA256) upstream package : 45041039893a844772e700769c2f8adbe20b1fcfbd3520516f6768ebf69dc66a https://github.com/libbpf/bpftool/archive/e17d6cf646e1b3107424386a62afc15a36b18f10/bpftool-7.2.0^20230926gite17d6cf.tar.gz : CHECKSUM(SHA256) this package : 3c6cf4f072431c640217c34cfd90b0b7374fcbafa06db9072a84147a7667951e CHECKSUM(SHA256) upstream package : 3c6cf4f072431c640217c34cfd90b0b7374fcbafa06db9072a84147a7667951e https://github.com/sched-ext/scx/archive/v0.1.7/scx-0.1.7.tar.gz : CHECKSUM(SHA256) this package : 2f1e0c04b88fae1aa3cbf6cd84a57024fd878c48da49f2abe503e7494272e1cb CHECKSUM(SHA256) upstream package : 2f1e0c04b88fae1aa3cbf6cd84a57024fd878c48da49f2abe503e7494272e1cb Requires -------- scx_c_schedulers (rpmlib, GLIBC filtered): ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libelf.so.1()(64bit) libelf.so.1(ELFUTILS_1.0)(64bit) libelf.so.1(ELFUTILS_1.3)(64bit) libelf.so.1(ELFUTILS_1.5)(64bit) libelf.so.1(ELFUTILS_1.6)(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.3.3)(64bit) rtld(GNU_HASH) scx_c_schedulers-debuginfo (rpmlib, GLIBC filtered): scx_c_schedulers-debugsource (rpmlib, GLIBC filtered): Provides -------- scx_c_schedulers: bundled(bpftool) bundled(libbpf) scx_c_schedulers scx_c_schedulers(aarch-64) scx_c_schedulers-debuginfo: debuginfo(build-id) scx_c_schedulers-debuginfo scx_c_schedulers-debuginfo(aarch-64) scx_c_schedulers-debugsource: scx_c_schedulers-debugsource scx_c_schedulers-debugsource(aarch-64) Diff spec file in url and in SRPM --------------------------------- --- /home/fedora/2264277-scx_c_schedulers/srpm/scx_c_schedulers.spec 2024-02-25 06:21:53.481289934 +0000 +++ /home/fedora/2264277-scx_c_schedulers/srpm-unpacked/scx_c_schedulers.spec 2024-02-16 00:00:00.000000000 +0000 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.6.1) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global toolchain clang @@ -22,5 +32,5 @@ # bundled libbpf: LGPL-2.1-only OR BSD-2-Clause # bpftool: GPL-2.0-only OR BSD-2-Clause -License: GPL-2.0-only AND (GPL-2.0-only OR BSD-2-Clause) AND (LGPL-2.1-only OR BSD-2-Clause) +License: GPL-2.0-only AND (GPL-2.0-only OR BSD-2-Clause) AND (LGPL-2.1 OR BSD-2-Clause) URL: https://github.com/sched-ext/scx @@ -87,3 +97,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Fri Feb 16 2024 John Doe <packager@xxxxxxxxxxx> - 0.1.7-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2264277 Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Ocaml, R, Java, fonts, Python, PHP, SugarActivity, Perl, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Is it possible to add a patch so that Cargo is not required. Probably affects: https://github.com/sched-ext/scx/blob/main/meson.build#L23 https://github.com/sched-ext/scx/blob/main/meson.build#L110-L155 b) The spec file packaged with the rpm has LGPL-2.1 instead of LGPL-2.1-only c) Not directly related to this review, but might a bpf SIG be a reasonable thing to have to update all bpf packages at once so that bundling is reduced? d) Should BREAKING_CHANGES.md and OVERVIEW.md also be packaged? e) Is it possible to run a smoke check for each binary, for example ./scx_simple -h f) Helpful to list all the binaries, though a preference not a requirement g) Using %exclude is not recommended, better to patch out or use sed to remove: https://github.com/sched-ext/scx/blob/main/meson.build#L170-L174 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2264277 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202264277%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
