https://bugzilla.redhat.com/show_bug.cgi?id=2263767 --- Comment #2 from Arthur Bols <arthur@xxxxxxxx> --- Some suggestions: ================= - You could use forgemeta macros instead of the gittag variable: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control - Package the manpage in debian/redsocks.8 - Debian and Ubuntu add a few patches consider implementing some of them The config file patch doesn't seem necessary, but I would definitely look at the libevent 2.1 patch. https://salsa.debian.org/debian/redsocks/-/tree/master/debian/patches?ref_type=heads Issues: ======= - Change BuildRequires: systemd to systemd-rpm-macros - Don't glob everything under a shared directory More info: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists - Incomplete %license field Some source files are under a different license (base64.c/h md5.c/h). The correct %license field is: Apache-2.0 AND LGPL-2.1-or-later AND Zlib Please provide a license breakdown above the %license field or in a separate file. Don't forget to add the Apache-2.0 and LGPL-2.1-or-later license files. - Change EnvironmentFile path in redsocks.service systemd unit: `EnvironmentFile=/etc/conf.d/redsocks` should be `EnvironmentFile=/etc/sysconfig/redsocks` This file also doesn't exists and is required as redsocks reads `./redsocks.conf` by default. - Add the `redsocks` user and group https://docs.fedoraproject.org/en-US/packaging-guidelines/#_users_and_groups - Add systemd scriptlets: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd - redsocks.conf needs changes The main problem is that the user and group is set to nobody, which is not allowed for system services in Fedora. I suggest using the debian/redsocks.conf config, or create your own. Ubuntu/Debian also change the `dest_ip` and `ip` options to 192.0.2.2 and 192.0.2.1 respectively, consider looking at those. I think they change it for privacy reasons. Sorry for all the extra work, but it will be a better package in the end! :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2263767 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202263767%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
