https://bugzilla.redhat.com/show_bug.cgi?id=2251448 Kan-Ru Chen <kanru@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kanru@xxxxxxxxxx --- Comment #7 from Kan-Ru Chen <kanru@xxxxxxxxxx> --- I also created a spec file without knowing that this bug existed. https://copr.fedorainfracloud.org/coprs/kanru/beancount/ Overall your package looks great. Just two small questions related to naming. > %global srcname beancount > %global forgeurl https://github.com/beancount/beancount > > Name: python-%{srcname} Would it make sense to name the srpm `beancount` instead? Python packaging guideline https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_application_naming > Packages that primarily provide applications, services or any kind of executables > SHOULD be named according to the general Fedora naming guidelines (e.g. ansible). Since upstream already release the package as `beancount` I feel this should be preferred. This also make the auto-generated debugsource and debuginfo package named correctly. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2251448 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251448%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
