https://bugzilla.redhat.com/show_bug.cgi?id=2265554 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > %global toolchain clang > %global _lto_cflags %{nil} Why are we setting these? We should be able to build with GCC just fine, and there's no explanation for why LTO needs to be disabled. > %undefine __cmake_in_source_build We already don't define in source builds on RHEL 9+, so this is superfluous. > BuildRequires: /usr/bin/xvfb-run We should be using "/usr/bin/wlheadless-run" instead. See man page: https://www.mankier.com/1/wlheadless-run -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2265554 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202265554%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
