https://bugzilla.redhat.com/show_bug.cgi?id=2260538 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@xxxxxxxx | |m) | --- Comment #7 from Neal Gompa <ngompa13@xxxxxxxxx> --- Spec review: > %undefine _disable_source_fetch This is not allowed. The Fedora build system does not provide internet access. > Version: %{getenv:_VERSION_} > Release: %{getenv:_RELEASE_} This is not allowed. These values need to be static and managed from the spec file. > BuildArch: %{getenv:_ARCH_} Ignoring the fact that this form is not allowed, this makes no sense and should be dropped. The build system will build for all architectures. > License: Apache License 2.0 This is not valid. This needs to be an SPDX license identifier tag. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names > BuildRequires: systemd I don't see a reason to require systemd when you only need the RPM macros. Instead, require "systemd-rpm-macros". > BuildRequires: clang llvm llvm-devel zlib-devel make libbpf Please format these such that each build dependency on its own line. > Requires: elfutils-libelf-devel Are you sure you need the devel package at runtime? > %ifarch x86_64 > GOARCH=amd64 > %endif You're going to need aliases for all RPM arches in Fedora to map to Go arches. > make genlibbpf _build_local GOOS=${GOOS} GOARCH=${GOARCH} ATTACHER_TAG=libbpf The Go compilation build flags need to be passed in. > install -d %{buildroot}/var/lib/kepler/data > install -d %{buildroot}/var/lib/kepler/bpfassets > install -d %{buildroot}/etc/kepler/kepler.config "/var/lib" should be "%{_sharedstatedir}" and "/etc" should be "%{_sysconfdir}". > install -p -m644 ./data/cpus.yaml %{buildroot}/var/lib/kepler/data/cpus.yaml > install -p -m644 ./data/model_weight/acpi_AbsPowerModel.json %{buildroot}/var/lib/kepler/data/acpi_AbsPowerModel.json > install -p -m644 ./data/model_weight/acpi_DynPowerModel.json %{buildroot}/var/lib/kepler/data/acpi_DynPowerModel.json > install -p -m644 ./data/model_weight/intel_rapl_AbsPowerModel.json %{buildroot}/var/lib/kepler/data/intel_rapl_AbsPowerModel.json > install -p -m644 ./data/model_weight/intel_rapl_DynPowerModel.json %{buildroot}/var/lib/kepler/data/intel_rapl_DynPowerModel.json Are you sure this should be in "%{_sharedstatedir}"? It seems like these are static files and should be installed into "%{_datadir}". > %post > > %systemd_post kepler.service This is incomplete. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd > /var/lib/kepler/bpfassets/amd64_kepler.bpf.o This should probably be installed into "%{_libexecdir}/kepler/bpfassets" instead. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2260538 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202260538%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
