https://bugzilla.redhat.com/show_bug.cgi?id=2253362 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #9 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Kai A. Hiller from comment #8) > Some of the noise in the spec file could be improved by working with > upstream to > change defaults, making the build more generic or adding build options. These > include basically all the changes in %prep and the patches, e.g.: > - Easy build without bundled libraries > - No arbitrary disabling of helpful compiler options > - lib and include locations Absolutely. I will work with upstream on these items. > Regarding libscip-doc: > - I don’t see anything licensed under GPL-1.0-or-later Doxygen adds some of the files, and doxygen is licensed GPL-1.0-or-later. I made a web page to help me keep track of such things: https://jamezone.org/pleasure/software/Fedora/license/ > - There is a bundled jquery.js that I think should be annotated (or even > unbundled?): > Provides: bundled(jquery) = 3.6.0 Good catch. I have updated the spec file with the Provides. Thank you for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2253362 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202253362%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
