https://bugzilla.redhat.com/show_bug.cgi?id=2265191 Jan Grulich <jgrulich@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Jan Grulich <jgrulich@xxxxxxxxxx> --- Looks good to me. Just minor issues that can be fixed during import. Naming: OK Licenses: OK Dependencies: OK Minor issues: 1) Both %{_qt6_libdir}/cmake/Qt6 and %dir %{_qt6_libdir}/cmake/Qt6Qml/QmlPlugins/ are not owned by this package. 2) #libQt6Core.so.6(Qt_5_PRIVATE_API)(64bit) → It's just a comment, but mentions Qt5 3) in -devel, I think "Requires: qt6-qtbase-devel%{?_isa}" is not necessary, it will get pulled through the deps anyway. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2265191 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202265191%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
