https://bugzilla.redhat.com/show_bug.cgi?id=2253361 --- Comment #8 from Jerry James <loganjerry@xxxxxxxxx> --- Benson, thank you so much for the review. (In reply to Benson Muite from comment #7) > Comments: > a) Please update to the latest release 7.0.0 Hmmm, I'm not sure what to do here. There is a release-700 tag on https://github.com/scipopt/soplex, but: - https://soplex.zib.de/index.php#news lists version 6.0.4 as the most recent version - https://github.com/scipopt/soplex/blob/master/CHANGELOG shows 6.0.4 as the most recent version, with other changes under "Next major release". - http://listserv.zib.de/pipermail/soplex/ does not show any announcement of a version 7.0.0 I get the impression that, the git tag notwithstanding, version 7.0.0 hasn't actually been released yet. I would like to stay with version 6.0.4 for now if that does not cause you concern. > b) License file does not contain full license text > https://github.com/scipopt/soplex/blob/master/LICENSE > maybe raise an issue upstream? Done: https://github.com/scipopt/soplex/issues/31 > c) In latest release, fmt is bundled and has a different license: > https://github.com/scipopt/soplex/tree/master/src/soplex/external/fmt Okay, I will deal with that when updating to 7.0.0. It uses fmt version 6.x, like papilo, which is incompatible with the version of fmt in Rawhide. We'll have to allow the bundling, along with adding the appropriate Provides and adding to the License field. > e) Consider upstreaming python3 patch It's kind of ugly. I've been meaning to make it a little prettier and submit it, but obviously haven't gotten around to it. I will schedule that for tomorrow. > f) Approved as above issues are not blocking, though still worth addressing. Thank you! I'll wait to hear your opinion on the 7.0.0 upgrade before importing. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2253361 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202253361%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
