https://bugzilla.redhat.com/show_bug.cgi?id=2262694 --- Comment #41 from Carlos Rodriguez-Fernandez <carlosrodrifernandez@xxxxxxxxx> --- Thank you for the update, Luya. This part is missing in the new revision: ``` ExcludeArch: i686 ``` Also, I'm having a hard time where is the `%{oiio}` defined, and there is also an extra `}` on it: `-DMATERIALX_BUILD_OIIO=%{oiio}} \` * The naming is actually better `materialx` than `libmaterialx`, because as you said, reflects better the upstream project name. * openshadinglanguage, OpenImageIO, and pybind11 are already packages in fedora that this package is depending on, so their license is not really necessary to be listed. * The incorporated modules will need to investigated more to see exactly how they are being "imported or incorporated". They should be packaged separately if possible, or use Provides: bundled(...) = <version> otherwise. That would faciliate tracking them for security, licensing, etc... - ambientcg (assets copied over) CC0-1.0 - poly-haven (assets copied over) CC0-1.0 - catch (2.13.10, it looks like source copied over) BSL-1.0 - glfw (3.4.0, it looks like source copied over) Zlib - nanogui (incorporated as gitsubmodule, but what version?) BSD-4-Clause - ImGui - ImGuiEditor - and pretty much all the ones in https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/THIRD-PARTY.md These are the git submodules I found related with NanoGUI, and also ImGui*: ``` $ git submodule status -9aae45eb4a05a5a1f96be1ef37eb503a12ceb889 source/MaterialXGraphEditor/External/ImGui -2f99b2d613a400f6579762bd7e7c343a0d844158 source/MaterialXGraphEditor/External/ImGuiNodeEditor -f5020e2f3e5114d517642e67afbb21cb88cf04c0 source/MaterialXView/NanoGUI ``` It looks like `CHANGELOG.md` can be a good source of details about the incorporated components, and how exactly they are brought in. I think it is better to have a senior packager pair of eyes looking into this, because of its complexity. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2262694 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202262694%23c41 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
