[Bug 218581] Review Request: mediawiki-openid - The OpenID extension for MediaWiki

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mediawiki-openid - The OpenID extension for MediaWiki


https://bugzilla.redhat.com/show_bug.cgi?id=218581





------- Additional Comments From lemenkov@xxxxxxxxx  2008-01-19 17:54 EST -------
REVIEW:

[-] rpmlint is not silent - just add empty %build section into spec-file
[+] The package named according to the Package Naming Guidelines.
[+] The spec file name matches the base package %{name}, in the format %{name}.spec 
[+] The package meets the Packaging Guidelines.
[+] The package licensed with a Fedora approved license and meet the Licensing
Guidelines.
[+] The License field in the package spec file matches the actual license.
[+] The spec file written in American English.
[+] The spec file for the package is legible. 
[+] The sources used to build the package matches the upstream source
[+] The package successfully builds.
[+] All build dependencies listed in BuildRequires.
[+] The package owns all directories that it creates.
[+] The package does not contain any duplicate files in the %files listing.
[+] Permissions on files are set properly.
[+] The package have a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[+] The package consistently use macros.
[+] The package contains code, or permissable content.
[+] Packages does not own files or directories already owned by other packages.
[+] All filenames in rpm packages are valid UTF-8.

SHOULD Items:

[-] You SHOULD query upstream to include License among sources. It's not a
blocker though.

Some notes: 

* The description of package rather big. Maybe it would be better to put it into
separate file? Saying, README.fedora or similar. Just my IMHO, actually and not
a blocker.

* From description I realized that openid_table.sql needs only for creating a
database in MySQL, so I think that we should separate this file from
php-scripts. Maybe we should move it into %doc section?

Just settle my two doubts, satisfy rpmlint with empty %build section and I'll
approve it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]