https://bugzilla.redhat.com/show_bug.cgi?id=2262694 --- Comment #36 from Carlos Rodriguez-Fernandez <carlosrodrifernandez@xxxxxxxxx> --- I'm using a non-rawhide review template since the rawhide one is broken. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: materialx : /usr/share/materialx/stdlib/genosl/include/color4.h materialx : /usr/share/materialx/stdlib/genosl/include/matrix33.h materialx : /usr/share/materialx/stdlib/genosl/include/mx_funcs.h materialx : /usr/share/materialx/stdlib/genosl/include/vector2.h materialx : /usr/share/materialx/stdlib/genosl/include/vector4.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Package contains BR: python2-devel or python3-devel ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [-]: Package does not contain kernel modules. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "BSD 3-Clause License", "*No copyright* Apache License", "Apache License 2.0", "MIT License", "*No copyright* ISC License", "BSD 3-Clause License and/or Lawrence Berkeley National Labs BSD variant license", "*No copyright* Apache License 2.0 and/or SIL Open Font License 1.1", "Apache License 2.0 and/or BSD 3-Clause License", "zlib License", "MIT License and/or The Unlicense", "*No copyright* MIT License", "Apache License 2.0 and/or Khronos License and/or MIT License", "Khronos License", "*No copyright* Boost Software License 1.0", "Boost Software License 1.0", "Simple Public License and/or zlib License", "*No copyright* The Unlicense [generated file]", "SIL Open Font License 1.1", "*No copyright* zlib License", "*No copyright* Public domain", "*No copyright* SIL Open Font License 1.1", "GNU Lesser General Public License v2.1 or later". 1358 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/materialx/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: python3-materialx (description) [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 44550 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ =]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 140707840 bytes in /usr/share materialx-1.38.8-1.fc39.x86_64.rpm:140697600 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: materialx-1.38.8-1.fc39.x86_64.rpm materialx-devel-1.38.8-1.fc39.x86_64.rpm python3-materialx-1.38.8-1.fc39.x86_64.rpm materialx-tools-1.38.8-1.fc39.x86_64.rpm materialx-debuginfo-1.38.8-1.fc39.x86_64.rpm materialx-debugsource-1.38.8-1.fc39.x86_64.rpm materialx-1.38.8-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpc80rq1fk')] checks: 32, packages: 7 materialx.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/materialx/CHANGELOG.md materialx.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/materialx/README.md materialx.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/materialx/SECURITY.md materialx.x86_64: E: wrong-script-end-of-line-encoding /usr/share/licenses/materialx/LICENSE materialx.x86_64: E: wrong-script-end-of-line-encoding /usr/share/licenses/materialx/THIRD-PARTY.md materialx-devel.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/materialx-devel/README.md python3-materialx.x86_64: E: wrong-script-end-of-line-encoding /usr/lib64/python3.12/site-packages/MaterialX/colorspace.py python3-materialx.x86_64: E: wrong-script-end-of-line-encoding /usr/lib64/python3.12/site-packages/MaterialX/datatype.py python3-materialx.x86_64: E: wrong-script-end-of-line-encoding /usr/lib64/python3.12/site-packages/MaterialX/main.py python3-materialx.x86_64: W: unexpanded-macro %description -l C %{description} materialx.x86_64: W: spurious-executable-perm /usr/share/doc/materialx/CHANGELOG.md materialx.x86_64: W: spurious-executable-perm /usr/share/doc/materialx/README.md materialx.x86_64: W: spurious-executable-perm /usr/share/doc/materialx/SECURITY.md materialx-devel.x86_64: W: spurious-executable-perm /usr/share/doc/materialx-devel/README.md materialx.x86_64: E: script-without-shebang /usr/share/licenses/materialx/LICENSE materialx.x86_64: E: script-without-shebang /usr/share/licenses/materialx/THIRD-PARTY.md python3-materialx.x86_64: E: non-executable-script /usr/lib64/python3.12/site-packages/MaterialX/colorspace.py 644 /usr/bin/python3 -sP python3-materialx.x86_64: E: non-executable-script /usr/lib64/python3.12/site-packages/MaterialX/datatype.py 644 /usr/bin/python3 -sP python3-materialx.x86_64: E: non-executable-script /usr/lib64/python3.12/site-packages/MaterialX/main.py 644 /usr/bin/python3 -sP materialx-tools.x86_64: W: no-manual-page-for-binary baketextures.py materialx-tools.x86_64: W: no-manual-page-for-binary generateshader.py materialx-tools.x86_64: W: no-manual-page-for-binary genmdl.py materialx-tools.x86_64: W: no-manual-page-for-binary mxdoc.py materialx-tools.x86_64: W: no-manual-page-for-binary mxformat.py materialx-tools.x86_64: W: no-manual-page-for-binary mxvalidate.py materialx-tools.x86_64: W: no-manual-page-for-binary translateshader.py materialx-tools.x86_64: W: no-manual-page-for-binary writenodegraphs.py materialx-tools.x86_64: W: no-documentation python3-materialx.x86_64: W: no-documentation materialx-tools.x86_64: E: no-binary materialx.x86_64: E: files-duplicated-waste 106863 materialx.x86_64: W: files-duplicate /usr/share/materialx/resources/Materials/TestSuite/libraries/metal/textures/mesh_wire_norm.png /usr/share/materialx/resources/Images/mesh_wire_norm.png materialx.x86_64: W: files-duplicate /usr/share/materialx/resources/Materials/TestSuite/pbrlib/bsdf/wedge_conductor.mtlx /usr/share/materialx/resources/Materials/TestSuite/pbrlib/bsdf/conductor.mtlx materialx.x86_64: W: files-duplicate /usr/share/materialx/stdlib/genmsl/mx_burn_float.metal /usr/share/materialx/stdlib/genglsl/mx_burn_float.glsl materialx.x86_64: W: files-duplicate /usr/share/materialx/stdlib/genmsl/mx_dodge_float.metal /usr/share/materialx/stdlib/genglsl/mx_dodge_float.glsl materialx.x86_64: W: files-duplicate /usr/share/materialx/stdlib/genmsl/mx_smoothstep_float.metal /usr/share/materialx/stdlib/genglsl/mx_smoothstep_float.glsl materialx.x86_64: W: devel-file-in-non-devel-package /usr/share/materialx/stdlib/genosl/include/color4.h materialx.x86_64: W: devel-file-in-non-devel-package /usr/share/materialx/stdlib/genosl/include/matrix33.h materialx.x86_64: W: devel-file-in-non-devel-package /usr/share/materialx/stdlib/genosl/include/mx_funcs.h materialx.x86_64: W: devel-file-in-non-devel-package /usr/share/materialx/stdlib/genosl/include/vector2.h materialx.x86_64: W: devel-file-in-non-devel-package /usr/share/materialx/stdlib/genosl/include/vector4.h python3-materialx.x86_64: W: description-shorter-than-summary 7 packages and 0 specfiles checked; 16 errors, 26 warnings, 553 filtered, 16 badness; has taken 6.5 s Rpmlint (debuginfo) ------------------- Checking: materialx-debuginfo-1.38.8-1.fc39.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmphrl4wv1n')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 30 filtered, 0 badness; has taken 1.6 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "python3-materialx". (none): E: there is no installed rpm "materialx-devel". (none): E: there is no installed rpm "materialx-debuginfo". (none): E: there is no installed rpm "materialx-tools". (none): E: there is no installed rpm "materialx". (none): E: there is no installed rpm "materialx-debugsource". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 6 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Unversioned so-files -------------------- python3-materialx: /usr/lib64/python3.12/site-packages/MaterialX/PyMaterialXCore.cpython-312-x86_64-linux-gnu.so python3-materialx: /usr/lib64/python3.12/site-packages/MaterialX/PyMaterialXFormat.cpython-312-x86_64-linux-gnu.so python3-materialx: /usr/lib64/python3.12/site-packages/MaterialX/PyMaterialXGenGlsl.cpython-312-x86_64-linux-gnu.so python3-materialx: /usr/lib64/python3.12/site-packages/MaterialX/PyMaterialXGenMdl.cpython-312-x86_64-linux-gnu.so python3-materialx: /usr/lib64/python3.12/site-packages/MaterialX/PyMaterialXGenMsl.cpython-312-x86_64-linux-gnu.so python3-materialx: /usr/lib64/python3.12/site-packages/MaterialX/PyMaterialXGenOsl.cpython-312-x86_64-linux-gnu.so python3-materialx: /usr/lib64/python3.12/site-packages/MaterialX/PyMaterialXGenShader.cpython-312-x86_64-linux-gnu.so python3-materialx: /usr/lib64/python3.12/site-packages/MaterialX/PyMaterialXRender.cpython-312-x86_64-linux-gnu.so python3-materialx: /usr/lib64/python3.12/site-packages/MaterialX/PyMaterialXRenderGlsl.cpython-312-x86_64-linux-gnu.so python3-materialx: /usr/lib64/python3.12/site-packages/MaterialX/PyMaterialXRenderOsl.cpython-312-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/AcademySoftwareFoundation/MaterialX/releases/download/v1.38.8/MaterialX-1.38.8.tar.gz : CHECKSUM(SHA256) this package : 6769800cc3c15a9ecc99933774824ed5a766382f71966ab607c22ca33a4d0162 CHECKSUM(SHA256) upstream package : 6769800cc3c15a9ecc99933774824ed5a766382f71966ab607c22ca33a4d0162 Requires -------- materialx (rpmlib, GLIBC filtered): libGLX.so.0()(64bit) libMaterialXCore.so.1()(64bit) libMaterialXFormat.so.1()(64bit) libMaterialXGenGlsl.so.1()(64bit) libMaterialXGenShader.so.1()(64bit) libMaterialXRender.so.1()(64bit) libMaterialXRenderHw.so.1()(64bit) libOpenImageIO.so.2.4()(64bit) libOpenImageIO_Util.so.2.4()(64bit) libX11.so.6()(64bit) libXt.so.6()(64bit) libasan.so.8()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libubsan.so.1()(64bit) rtld(GNU_HASH) materialx-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) libMaterialXCore.so.1()(64bit) libMaterialXFormat.so.1()(64bit) libMaterialXGenGlsl.so.1()(64bit) libMaterialXGenMdl.so.1()(64bit) libMaterialXGenMsl.so.1()(64bit) libMaterialXGenOsl.so.1()(64bit) libMaterialXGenShader.so.1()(64bit) libMaterialXRender.so.1()(64bit) libMaterialXRenderGlsl.so.1()(64bit) libMaterialXRenderHw.so.1()(64bit) libMaterialXRenderOsl.so.1()(64bit) materialx(x86-64) python3-materialx (rpmlib, GLIBC filtered): libMaterialXCore.so.1()(64bit) libMaterialXFormat.so.1()(64bit) libMaterialXGenGlsl.so.1()(64bit) libMaterialXGenMdl.so.1()(64bit) libMaterialXGenMsl.so.1()(64bit) libMaterialXGenOsl.so.1()(64bit) libMaterialXGenShader.so.1()(64bit) libMaterialXRender.so.1()(64bit) libMaterialXRenderGlsl.so.1()(64bit) libMaterialXRenderOsl.so.1()(64bit) libasan.so.8()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libubsan.so.1()(64bit) materialx(x86-64) python(abi) rtld(GNU_HASH) materialx-tools (rpmlib, GLIBC filtered): /usr/bin/python3 python3-materialx(x86-64) materialx-debuginfo (rpmlib, GLIBC filtered): materialx-debugsource (rpmlib, GLIBC filtered): Provides -------- materialx: libMaterialXCore.so.1()(64bit) libMaterialXFormat.so.1()(64bit) libMaterialXGenGlsl.so.1()(64bit) libMaterialXGenMdl.so.1()(64bit) libMaterialXGenMsl.so.1()(64bit) libMaterialXGenOsl.so.1()(64bit) libMaterialXGenShader.so.1()(64bit) libMaterialXRender.so.1()(64bit) libMaterialXRenderGlsl.so.1()(64bit) libMaterialXRenderHw.so.1()(64bit) libMaterialXRenderOsl.so.1()(64bit) materialx materialx(x86-64) materialx-devel: cmake(MaterialX) cmake(materialx) materialx-devel materialx-devel(x86-64) python3-materialx: python-materialx python3-materialx python3-materialx(x86-64) python3.12-materialx materialx-tools: materialx-tools materialx-tools(x86-64) materialx-debuginfo: debuginfo(build-id) libMaterialXCore.so.1.38.8-1.38.8-1.fc39.x86_64.debug()(64bit) libMaterialXFormat.so.1.38.8-1.38.8-1.fc39.x86_64.debug()(64bit) libMaterialXGenGlsl.so.1.38.8-1.38.8-1.fc39.x86_64.debug()(64bit) libMaterialXGenMdl.so.1.38.8-1.38.8-1.fc39.x86_64.debug()(64bit) libMaterialXGenMsl.so.1.38.8-1.38.8-1.fc39.x86_64.debug()(64bit) libMaterialXGenOsl.so.1.38.8-1.38.8-1.fc39.x86_64.debug()(64bit) libMaterialXGenShader.so.1.38.8-1.38.8-1.fc39.x86_64.debug()(64bit) libMaterialXRender.so.1.38.8-1.38.8-1.fc39.x86_64.debug()(64bit) libMaterialXRenderGlsl.so.1.38.8-1.38.8-1.fc39.x86_64.debug()(64bit) libMaterialXRenderHw.so.1.38.8-1.38.8-1.fc39.x86_64.debug()(64bit) libMaterialXRenderOsl.so.1.38.8-1.38.8-1.fc39.x86_64.debug()(64bit) materialx-debuginfo materialx-debuginfo(x86-64) materialx-debugsource: materialx-debugsource materialx-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name materialx --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-x86_64 Active plugins: Python, Shell-api, Generic, C/C++ Disabled plugins: R, Perl, Ocaml, Java, SugarActivity, PHP, Haskell, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2262694 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202262694%23c36 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
