[Bug 2258034] Review Request: python-fortranformat - reading and writing fortran style from python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2258034



--- Comment #13 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
On second look, it appears the Makefile is kind of just an example. It is set
up by default to generate tests (using our Fortran compiler) into
tests/autogen/{input,output}/gfortran/10_2_0_osx_intel, but then test against
tests/autogen/{input,output}/ifort/9_1_linux_intel.

I’m trying replacing

  # This takes a long time!
  %make_build compilertests

with

  # The name of this directory is not really important; we imitate the upstream
  # convention so that bug reports make more sense.
  test_dir="$(gfortran -dumpfullversion | tr . _)_linux_%{_arch}"
  pushd tests/autogen/generate
  # This takes a long time!
  %{python3} gen_input_tests.py 'gfortran %s -o %s' "${test_dir}"
  %{python3} gen_output_tests.py 'gfortran %s -o %s' "${test_dir}"
  popd

and

  %if %{with tests}
  %if %{without minimal_tests}
  # At least run the hand-written tests:
  %pytest tests/handwritten
  %endif
  %if %{with minimal_tests}
  %py3_test_envvars %make_build runminimaltests
  %endif
  %if %{with full_tests}
  %py3_test_envvars %make_build runtests
  %endif
  %endif

with

  %if %{with tests}
  %pytest tests/handwritten
  %if %{with minimal_tests}
  %pytest tests/minimal
  %endif
  %if %{with full_tests}
  test_dir="$(gfortran -dumpfullversion | tr . _)_linux_%{_arch}"
  %pytest "tests/autogen/input/ifort/${test_dir}"
  %pytest "tests/autogen/output/ifort/${test_dir}"
  %endif
  %endif

I think this is the right approach, but we’ll see if it’s enough to get the
full tests passing.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2258034

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202258034%23c13
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux