https://bugzilla.redhat.com/show_bug.cgi?id=2259760 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Doc Type|--- |If docs needed, set a value CC| |decathorpe@xxxxxxxxx Flags| |fedora-review+ Status|NEW |ASSIGNED --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass (there are no tests) - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - licenses of statically linked dependencies are correctly taken into account - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Note that the package includes a few files that should not be installed into the rust-oxipng-devel package: - /scripts/ - /Dockerfile - /index.html In particular, the files in the "scripts" folder cause the package to have a generated dependency on /usr/bin/bash. Please exclude these two files and the "scripts" folder in some way from the -devel package. Option 1: Patching Cargo.toml to update the "exclude" list, or Option 2: Using the %exclude directive in the %files list. If you go with Option 1, that patch might be acceptable by upstream too. They already exclude benchmark and test sources, so they probably don't want to ship other development-only files either. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2259760 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202259760%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
