https://bugzilla.redhat.com/show_bug.cgi?id=2260793 Sergio Basto <sergio@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #48 from Sergio Basto <sergio@xxxxxxxxxx> --- from review on 12 Fev https://download.copr.fedorainfracloud.org/results/%40fedora-review/fedora-review-2260793-kwin-x11/fedora-40-x86_64/06981267-kwin-x11/fedora-review/review.txt Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in kwin-x11 See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_user_units (In reply to Kevin Kofler from comment #4) > The BuildRequires are copied from kwin. The Qt/KDE -devel files drag in > gcc-c++ transitively, but I suppose I could add it explicitly. I don't have an opinion it is an detail which doesn't change anything . > The systemd user units are shipped the same way (without scriptlets) in the > current kwin-wayland and (pre-Rawhide) kwin-x11 subpackages. I am not sure > whether it is a good idea to add the scriptlets or not. /usr/lib/systemd/user/plasma-kwin_x11.service is a service added user unitdir seems to me correctly please remove Epoch before import the package no more issues PACKAGE APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2260793 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202260793%23c48 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
