https://bugzilla.redhat.com/show_bug.cgi?id=2264277 --- Comment #5 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- The spec file lists only GPL-2.0-only license, yet there are BSD-2-clause and LGPL-2.0 licenses in the bundled libbpf. These should also be listed in the spec file, and ideally a license breakdown also given. Maybe helpful to explain in the spec file why Clang is used rather than the default GCC. Warnings from fedora-review (spelling errors and manual page entries can be ignored): scx_c_schedulers.aarch64: W: summary-not-capitalized sched_ext schedulers written in c scx_c_schedulers.src: W: summary-not-capitalized sched_ext schedulers written in c scx_c_schedulers.aarch64: E: spelling-error ('flatcg', '%description -l en_US flatcg -> flat cg, flat-cg, flatcar') scx_c_schedulers.src: E: spelling-error ('flatcg', '%description -l en_US flatcg -> flat cg, flat-cg, flatcar') scx_c_schedulers.src: E: spelling-error ('qmap', '%description -l en_US qmap -> map, q map') scx_c_schedulers.src: E: spelling-error ('userland', '%description -l en_US userland -> user land, user-land, slanderous') scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_central scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_flatcg scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_nest scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_pair scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_qmap scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_simple scx_c_schedulers.aarch64: W: position-independent-executable-suggested /usr/bin/scx_userland scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_central scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_flatcg scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_nest scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_pair scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_qmap scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_simple scx_c_schedulers.aarch64: W: no-manual-page-for-binary scx_userland scx_c_schedulers-debugsource.aarch64: E: files-duplicated-waste 100043 scx_c_schedulers.aarch64: E: description-line-too-long "scx_central", "scx_flatcg", "scx_nest", "scx_pair", "scx_qmap", "scx _simple", 'scx_userland'. scx_c_schedulers.src: E: description-line-too-long "scx_central", "scx_flatcg", "scx_nest", "scx_pair", "scx_qmap", "scx_sim ple", 'scx_userland'. 4 packages and 0 specfiles checked; 9 errors, 16 warnings, 49 filtered, 9 badness; has taken 1.4 s -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2264277 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202264277%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue